[server] remove unused getFeaturedRepositories (#19100)

Author: AlexTugarev

components/dashboard/src/service/service-mock.ts

@@ -157,9 +157,6 @@ const gitpodServiceMock = createServiceMock({
     getWorkspaces: async () => {
         return [];
     },
-    getFeaturedRepositories: async () => {
-        return [];
-    },
     getAuthProviders: async () => {
         return [
             {

components/gitpod-db/src/typeorm/entity/db-repository-whitelist.ts

@@ -14,7 +14,6 @@ import {
     RunningWorkspaceInfo,
     Snapshot,
     SnapshotState,
-    WhitelistedRepository,
     Workspace,
     WorkspaceAndInstance,
     WorkspaceInfo,
@@ -44,7 +43,6 @@ import {
 import { DBPrebuildInfo } from "./entity/db-prebuild-info-entry";
 import { DBPrebuiltWorkspace } from "./entity/db-prebuilt-workspace";
 import { DBPrebuiltWorkspaceUpdatable } from "./entity/db-prebuilt-workspace-updatable";
-import { DBRepositoryWhiteList } from "./entity/db-repository-whitelist";
 import { DBSnapshot } from "./entity/db-snapshot";
 import { DBWorkspace } from "./entity/db-workspace";
 import { DBWorkspaceInstance } from "./entity/db-workspace-instance";
@@ -88,10 +86,6 @@ export class TypeORMWorkspaceDBImpl extends TransactionalDBImpl<WorkspaceDB> imp
         return (await this.getEntityManager()).getRepository<DBWorkspaceInstanceUser>(DBWorkspaceInstanceUser);
     }
 
-    private async getRepositoryWhitelist(): Promise<Repository<DBRepositoryWhiteList>> {
-        return (await this.getEntityManager()).getRepository<DBRepositoryWhiteList>(DBRepositoryWhiteList);
-    }
-
     private async getSnapshotRepo(): Promise<Repository<DBSnapshot>> {
         return (await this.getEntityManager()).getRepository<DBSnapshot>(DBSnapshot);
     }
@@ -629,31 +623,6 @@ export class TypeORMWorkspaceDBImpl extends TransactionalDBImpl<WorkspaceDB> imp
         });
     }
 
-    public async isWhitelisted(repositoryUrl: string): Promise<boolean> {
-        const whitelist = await this.getRepositoryWhitelist();
-        const repoCount = await whitelist
-            .createQueryBuilder("rwl")
-            .select("1")
-            .where("rwl.url = :url", { url: repositoryUrl })
-            .getCount();
-        return repoCount > 0;
-    }
-
-    public async getFeaturedRepositories(): Promise<Partial<WhitelistedRepository>[]> {
-        const whitelist = await this.getRepositoryWhitelist();
-        const allRepos = await whitelist
-            .createQueryBuilder("rwl")
-            .where("rwl.priority >= :minPrio", { minPrio: DBRepositoryWhiteList.MIN_FEATURED_REPOSITORY_PRIO })
-            .orderBy("priority", "DESC")
-            .getMany();
-        return allRepos.map((repo) => {
-            return {
-                url: repo.url,
-                description: repo.description,
-            };
-        });
-    }
-
     public async findSnapshotById(snapshotId: string): Promise<Snapshot | undefined> {
         const snapshots = await this.getSnapshotRepo();
         return snapshots.findOne(snapshotId);

components/gitpod-db/src/typeorm/workspace-db-impl.ts

@@ -11,7 +11,6 @@ import {
     WorkspaceInfo,
     WorkspaceInstance,
     WorkspaceInstanceUser,
-    WhitelistedRepository,
     Snapshot,
     PrebuiltWorkspace,
     PrebuiltWorkspaceUpdatable,
@@ -142,9 +141,6 @@ export interface WorkspaceDB {
         includeStopping?: boolean,
     ): Promise<RunningWorkspaceInfo[]>;
 
-    isWhitelisted(repositoryUrl: string): Promise<boolean>;
-    getFeaturedRepositories(): Promise<Partial<WhitelistedRepository>[]>;
-
     findSnapshotById(snapshotId: string): Promise<Snapshot | undefined>;
     findSnapshotsWithState(
         state: SnapshotState,

components/gitpod-db/src/workspace-db.ts

@@ -41,7 +41,6 @@ type APIInterface interface {
 	GetWorkspaces(ctx context.Context, options *GetWorkspacesOptions) (res []*WorkspaceInfo, err error)
 	GetWorkspaceOwner(ctx context.Context, workspaceID string) (res *UserInfo, err error)
 	GetWorkspaceUsers(ctx context.Context, workspaceID string) (res []*WorkspaceInstanceUser, err error)
-	GetFeaturedRepositories(ctx context.Context) (res []*WhitelistedRepository, err error)
 	GetWorkspace(ctx context.Context, id string) (res *WorkspaceInfo, err error)
 	GetIDEOptions(ctx context.Context) (res *IDEOptions, err error)
 	IsWorkspaceOwner(ctx context.Context, workspaceID string) (res bool, err error)
@@ -144,8 +143,6 @@ const (
 	FunctionGetWorkspaceOwner FunctionName = "getWorkspaceOwner"
 	// FunctionGetWorkspaceUsers is the name of the getWorkspaceUsers function
 	FunctionGetWorkspaceUsers FunctionName = "getWorkspaceUsers"
-	// FunctionGetFeaturedRepositories is the name of the getFeaturedRepositories function
-	FunctionGetFeaturedRepositories FunctionName = "getFeaturedRepositories"
 	// FunctionGetWorkspace is the name of the getWorkspace function
 	FunctionGetWorkspace FunctionName = "getWorkspace"
 	// FunctionGetIDEOptions is the name of the getIDEOptions function
@@ -686,24 +683,6 @@ func (gp *APIoverJSONRPC) GetWorkspaceUsers(ctx context.Context, workspaceID str
 	return
 }
 
-// GetFeaturedRepositories calls getFeaturedRepositories on the server
-func (gp *APIoverJSONRPC) GetFeaturedRepositories(ctx context.Context) (res []*WhitelistedRepository, err error) {
-	if gp == nil {
-		err = errNotConnected
-		return
-	}
-	var _params []interface{}
-
-	var result []*WhitelistedRepository
-	err = gp.C.Call(ctx, "getFeaturedRepositories", _params, &result)
-	if err != nil {
-		return
-	}
-	res = result
-
-	return
-}
-
 // GetWorkspace calls getWorkspace on the server
 func (gp *APIoverJSONRPC) GetWorkspace(ctx context.Context, id string) (res *WorkspaceInfo, err error) {
 	if gp == nil {
@@ -1907,14 +1886,6 @@ type Configuration struct {
 	GarbageCollectionStartDate  float64 `json:"garbageCollectionStartDate,omitempty"`
 }
 
-// WhitelistedRepository is the WhitelistedRepository message type
-type WhitelistedRepository struct {
-	Avatar      string `json:"avatar,omitempty"`
-	Description string `json:"description,omitempty"`
-	Name        string `json:"name,omitempty"`
-	URL         string `json:"url,omitempty"`
-}
-
 // EnvVar is the EnvVar message type
 type EnvVar struct {
 	ID    string `json:"id,omitempty"`

components/gitpod-protocol/go/gitpod-service.go

@@ -9,7 +9,6 @@ import {
     WorkspaceInfo,
     WorkspaceCreationResult,
     WorkspaceInstanceUser,
-    WhitelistedRepository,
     WorkspaceImageBuild,
     AuthProviderInfo,
     Token,
@@ -109,7 +108,6 @@ export interface GitpodServer extends JsonRpcServer<GitpodClient>, AdminServer,
     getWorkspaces(options: GitpodServer.GetWorkspacesOptions): Promise<WorkspaceInfo[]>;
     getWorkspaceOwner(workspaceId: string): Promise<UserInfo | undefined>;
     getWorkspaceUsers(workspaceId: string): Promise<WorkspaceInstanceUser[]>;
-    getFeaturedRepositories(): Promise<WhitelistedRepository[]>;
     getSuggestedRepositories(organizationId: string): Promise<SuggestedRepository[]>;
     searchRepositories(params: SearchRepositoriesParams): Promise<SuggestedRepository[]>;
     /**

components/gitpod-protocol/go/mock.go

@@ -1072,13 +1072,6 @@ export interface PrebuiltWorkspaceUpdatable {
     contextUrl?: string;
 }
 
-export interface WhitelistedRepository {
-    url: string;
-    name: string;
-    description?: string;
-    avatar?: string;
-}
-
 export type PortOnOpen = "open-browser" | "open-preview" | "notify" | "ignore";
 
 export interface PortConfig {

components/gitpod-protocol/src/gitpod-service.ts

@@ -63,7 +63,6 @@ const defaultFunctions: FunctionsConfig = {
     getWorkspaces: { group: "default", points: 1 },
     getWorkspaceOwner: { group: "default", points: 1 },
     getWorkspaceUsers: { group: "default", points: 1 },
-    getFeaturedRepositories: { group: "default", points: 1 },
     getSuggestedRepositories: { group: "default", points: 1 },
     searchRepositories: { group: "default", points: 1 },
     getWorkspace: { group: "default", points: 1 },

components/gitpod-protocol/src/protocol.ts

@@ -35,7 +35,6 @@ import {
     User,
     UserEnvVarValue,
     UserInfo,
-    WhitelistedRepository,
     Workspace,
     WorkspaceContext,
     WorkspaceCreationResult,
@@ -106,7 +105,6 @@ import { HostContextProvider } from "../auth/host-context-provider";
 import { GuardedResource, ResourceAccessGuard, ResourceAccessOp } from "../auth/resource-access";
 import { Config } from "../config";
 import { NotFoundError, UnauthorizedError } from "../errors";
-import { RepoURL } from "../repohost/repo-url";
 import { AuthorizationService } from "../user/authorization-service";
 import { TokenProvider } from "../user/token-provider";
 import { UserAuthentication } from "../user/user-authentication";
@@ -1327,41 +1325,6 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable {
         return prebuild;
     }
 
-    public async getFeaturedRepositories(ctx: TraceContext): Promise<WhitelistedRepository[]> {
-        const user = await this.checkAndBlockUser("getFeaturedRepositories");
-        const repositories = await this.workspaceDb.trace(ctx).getFeaturedRepositories();
-        if (repositories.length === 0) return [];
-
-        return (
-            await Promise.all(
-                repositories
-                    .filter((repo) => repo.url != undefined)
-                    .map(async (whitelistedRepo) => {
-                        const repoUrl = RepoURL.parseRepoUrl(whitelistedRepo.url!);
-                        if (!repoUrl) return undefined;
-
-                        const { host, owner, repo } = repoUrl;
-                        const hostContext = this.hostContextProvider.get(host);
-                        if (!hostContext || !hostContext.services) {
-                            return undefined;
-                        }
-                        const repoProvider = hostContext.services.repositoryProvider;
-                        try {
-                            const repository = await repoProvider.getRepo(user, owner, repo);
-                            return {
-                                url: repository.webUrl,
-                                name: repository.name,
-                                description: whitelistedRepo.description || repository.description,
-                                avatar: repository.avatarUrl,
-                            };
-                        } catch {
-                            // this happens quite often if only GitLab is enabled
-                        }
-                    }),
-            )
-        ).filter((e) => e !== undefined) as WhitelistedRepository[];
-    }
-
     public async getSuggestedRepositories(ctx: TraceContext, organizationId: string): Promise<SuggestedRepository[]> {
         traceAPIParams(ctx, { organizationId });