Skip to content

Commit 3fae0d1

Browse files
committed
only if actually called
1 parent 31b8c3b commit 3fae0d1

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

components/dashboard/src/service/service.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,14 @@ export function getGitpodService(): GitpodService {
6060
const service = _gp.gitpodService || (_gp.gitpodService = createGitpodService());
6161
service.server = new Proxy(service.server, {
6262
get(target, propKey) {
63-
return function (...args: any[]) {
63+
return async function (...args: any[]) {
64+
// TODO(ak) feature flagged
6465
if (propKey === "getWorkspace") {
65-
// TODO(ak) feature flagged
66-
helloService.sayHello({}).catch(console.error);
66+
try {
67+
return await target[propKey](...args);
68+
} finally {
69+
helloService.sayHello({}).catch(console.error);
70+
}
6771
}
6872
return target[propKey](...args);
6973
};

components/server/src/api/dummy.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ import { injectable } from "inversify";
2020
* - server-side observability
2121
* - client-side observability
2222
* - rate limitting
23+
* - logging context
24+
* - feature flags for unary and stream tests
25+
* - SLOs
26+
* - alerting
2327
*/
2428
@injectable()
2529
export class APIHelloService implements ServiceImpl<typeof HelloService> {

0 commit comments

Comments
 (0)