[ws-manger-mk2] Set owner reference

Author: Furisto

components/ws-daemon/pkg/controller/snapshot_controller.go

@@ -115,12 +115,7 @@ func (ssc *SnapshotReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 			snapshot.Status.Error = fmt.Errorf("could not take snapshot: %w", snapshotErr).Error()
 		}
 
-		err = ssc.Status().Update(ctx, &snapshot)
-		if err != nil {
-			return err
-		}
-
-		return ssc.Client.Delete(ctx, &snapshot)
+		return ssc.Status().Update(ctx, &snapshot)
 	})
 
 	if err != nil {

components/ws-manager-mk2/service/manager.go

@@ -522,18 +522,21 @@ func (wsm *WorkspaceManagerServer) TakeSnapshot(ctx context.Context, req *wsmana
 			APIVersion: workspacev1.GroupVersion.String(),
 			Kind:       "Snapshot",
 		},
-
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      fmt.Sprintf("%s-%d", req.Id, time.Now().UnixNano()),
 			Namespace: wsm.Config.Namespace,
-			Labels:    map[string]string{},
 		},
 		Spec: workspacev1.SnapshotSpec{
 			NodeName:    ws.Status.Runtime.NodeName,
 			WorkspaceID: ws.Name,
 		},
 	}
 
+	err = controllerutil.SetOwnerReference(&ws, &snapshot, wsm.Client.Scheme())
+	if err != nil {
+		return nil, status.Errorf(codes.Internal, "cannot set owner for snapshot: %q", err)
+	}
+
 	err = wsm.Client.Create(ctx, &snapshot)
 	if err != nil {
 		return nil, status.Errorf(codes.Internal, "cannot create snapshot object: %q", err)
@@ -580,8 +583,6 @@ func (wsm *WorkspaceManagerServer) TakeSnapshot(ctx context.Context, req *wsmana
 		}
 	}
 
-	log.Info("return url")
-
 	return &wsmanapi.TakeSnapshotResponse{
 		Url: sso.Status.URL,
 	}, nil