[public-api] Explicit panic handler (#17105)

Author: easyCZ

components/public-api-server/middleware/logging.go

@@ -17,15 +17,21 @@ type Middleware func(handler http.Handler) http.Handler
 func NewLoggingMiddleware() Middleware {
 	return func(next http.Handler) http.Handler {
 		logging := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			ctx := log.ToContext(r.Context(), log.Log.WithContext(r.Context()))
+			log.AddFields(ctx, logrus.Fields{
+				"protocol": "http",
+				"uri":      r.RequestURI,
+				"method":   r.Method,
+			})
+
 			start := time.Now()
 			next.ServeHTTP(w, r)
 			duration := time.Since(start)
 
-			log.WithFields(logrus.Fields{
-				"uri":      r.RequestURI,
-				"method":   r.Method,
-				"duration": duration,
-			}).Debug("Handled HTTP request")
+			log.AddFields(ctx, logrus.Fields{
+				"duration_seconds": duration.Seconds(),
+			})
+			log.Extract(ctx).Debug("Handled HTTP request")
 		})
 
 		return logging

components/public-api-server/pkg/server/logs.go

@@ -59,6 +59,10 @@ func NewLogInterceptor(entry *logrus.Entry) connect.UnaryInterceptorFunc {
 }
 
 func filterHeaders(headers http.Header) http.Header {
+	if headers == nil {
+		return nil
+	}
+
 	cloned := headers.Clone()
 	cloned.Del("Authorization")
 	cloned.Del("Cookie")

components/public-api-server/pkg/server/server.go

@@ -18,6 +18,7 @@ import (
 	"github.com/gitpod-io/gitpod/common-go/experiments"
 	"github.com/gitpod-io/gitpod/common-go/log"
 	"github.com/go-chi/chi/v5"
+	chi_middleware "github.com/go-chi/chi/v5/middleware"
 	"github.com/redis/go-redis/v9"
 	"gorm.io/gorm"
 
@@ -176,6 +177,7 @@ func register(srv *baseserver.Server, deps *registerDependencies) error {
 	}
 
 	rootHandler := chi.NewRouter()
+	rootHandler.Use(chi_middleware.Recoverer)
 	rootHandler.Use(middleware.NewLoggingMiddleware())
 
 	handlerOptions := []connect.HandlerOption{