Skip to content

Commit 4a44f13

Browse files
authored
[jb] nudge to improve integration tests (#17085)
1 parent 88274a4 commit 4a44f13

File tree

2 files changed

+33
-7
lines changed

2 files changed

+33
-7
lines changed

.github/workflows/jetbrains-update-plugin-platform-template.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,11 @@ jobs:
4444
run: |
4545
URL="https://data.services.jetbrains.com/products/releases?code=${{ inputs.productCode }}&type=${{ inputs.productType }}&platform=linux"
4646
echo "URL: $URL"
47-
BUILD=$(curl -s "$URL" |jq -r ".${{ inputs.productCode }}[0].build")
47+
RELEASE=$(curl -s "$URL" |jq ".${{ inputs.productCode }}[0]")
48+
MAJOR_VERSION=$(echo $RELEASE |jq -r ".majorVersion")
49+
echo "MAJOR_VERSION: $MAJOR_VERSION"
50+
51+
BUILD=$(echo $RELEASE |jq -r ".build")
4852
echo "BUILD: $BUILD"
4953
MAJOR=$(cut -d. -f1 <<< $BUILD)
5054
echo "MAJOR: $MAJOR"
@@ -53,11 +57,13 @@ jobs:
5357
LATEST_VERSION="$MAJOR.$MINOR-EAP-CANDIDATE-SNAPSHOT"
5458
echo "Latest platform version: $LATEST_VERSION"
5559
echo "::set-output name=result::$LATEST_VERSION"
60+
echo "::set-output name=majorVersion::$MAJOR_VERSION"
5661
- name: Update ${{ inputs.gradlePropertiesPath }}
5762
if: ${{ steps.latest-version.outputs.result != steps.current-version.outputs.result }}
5863
run: |
5964
PLUGIN_SINCE_BUILD=$(echo "${{ steps.latest-version.outputs.result }}" | sed 's/-EAP-CANDIDATE-SNAPSHOT//' | sed 's/-CUSTOM-SNAPSHOT//')
6065
sed -i "s/pluginSinceBuild=.*/pluginSinceBuild=$PLUGIN_SINCE_BUILD/" ${{ inputs.gradlePropertiesPath }}
66+
sed -i "s/pluginVerifierIdeVersions=.*/pluginVerifierIdeVersions=${{ steps.latest-version.outputs.majorVersion }}/" ${{ inputs.gradlePropertiesPath }}
6167
sed -i 's/platformVersion=${{ steps.current-version.outputs.result }}/platformVersion=${{ steps.latest-version.outputs.result }}/' ${{ inputs.gradlePropertiesPath }}
6268
git diff
6369
- name: Create Pull Request for Gateway Plugin
@@ -71,12 +77,19 @@ jobs:
7177
This PR updates the Platform Version from ${{ inputs.pluginName }} to the latest version.
7278
7379
## How to test
80+
81+
Merge if tests are green, if something breaks then add tests for regressions.
82+
83+
<details>
84+
<summary>if you want to test manually for some reasons</summary>
85+
7486
1. Ensure you have the Gateway installed from [JetBrains Toolbox App](https://www.jetbrains.com/toolbox-app/) and have it up-to-date.
7587
- You should use Gateway version corresponding to plugin qualifier, i.e. for stable plugin test with released, for latest test with EAP.
7688
- It could be that a new Gateway is not published for the given SDK yet then wait for it to be published. You can check the build version in the About dialog.
7789
2. Download the plugin build related to this branch in [Dev Versions](https://plugins.jetbrains.com/plugin/18438-gitpod-gateway/versions/dev), and [install it on the Gateway](https://www.jetbrains.com/help/idea/managing-plugins.html#install_plugin_from_disk).
7890
- You can also uninstall current Gitpod plugin, configure dev channel using https://plugins.jetbrains.com/plugins/list?channel=dev&pluginId=18438-gitpod-gateway and restart GW to test that the proper version is detected and installed.
7991
3. Create a new workspace from the Gateway (it's ok to use the pre-selected IDE and Repository) and confirm if JetBrains Client can connect to it.
92+
</details>
8093
8194
## Release Notes
8295
```release-note
@@ -114,11 +127,17 @@ jobs:
114127
This PR updates the Platform Version from ${{ inputs.pluginName }} to the latest version.
115128
116129
## How to test
130+
131+
Merge if tests are green, if something breaks then add tests for regressions.
132+
133+
<details>
134+
<summary>if you want to test manually for some reasons</summary>
117135
1. Open the preview environment generated for this branch
118136
2. Choose the _Latest Release (Unstable)_ version of IntelliJ IDEA as your preferred editor
119137
3. Start a workspace using this repository: https://github.com/gitpod-samples/spring-petclinic
120138
4. Verify that the workspace starts successfully
121139
5. Verify that the IDE opens successfully
140+
</details>
122141
123142
## Release Notes
124143
```release-note

.github/workflows/jetbrains-updates.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,25 @@ jobs:
3232
This PR updates the JetBrains IDE images to the most recent `stable` version.
3333
3434
## How to test
35+
36+
Merge if tests are green, if something breaks then add tests for regressions.
37+
38+
<details>
39+
<summary>if you want to test manually for some reasons</summary>
40+
3541
1. For each IDE changed on this PR, follow these steps:
36-
1. Open the preview environment generated for this branch
37-
1. Choose the stable version of the IDE that you're testing as your default editor
38-
1. Start a workspace using any repository (e.g: `https://github.com/gitpod-io/empty`)
39-
1. Verify that the workspace starts successfully
40-
1. Verify that the IDE opens successfully
41-
1. Verify that the version of the IDE corresponds to the one being updated in this PR
42+
2. Open the preview environment generated for this branch
43+
3. Choose the stable version of the IDE that you're testing as your default editor
44+
4. Start a workspace using any repository (e.g: `https://github.com/gitpod-io/empty`)
45+
5. Verify that the workspace starts successfully
46+
6. Verify that the IDE opens successfully
47+
7. Verify that the version of the IDE corresponds to the one being updated in this PR
4248
4349
The following resources should help, in case something goes wrong (e.g. workspaces don't start):
4450
4551
- https://www.gitpod.io/docs/troubleshooting#gitpod-logs-in-jetbrains-gateway
4652
- https://docs.google.com/document/d/1K9PSB0G6NwX2Ns_SX_HEgMYTKYsgMJMY2wbh0p6t3lQ
53+
</details>
4754
4855
## Release Notes
4956
```release-note

0 commit comments

Comments
 (0)