wip

Author: geropl

components/server/src/workspace/workspace-starter.ts

@@ -131,6 +131,7 @@ import { SYSTEM_USER } from "../authorization/authorizer";
 import { EnvVarService, ResolvedEnvVars } from "../user/env-var-service";
 import { RedlockAbortSignal } from "redlock";
 import { getExperimentsClientForBackend } from "@gitpod/gitpod-protocol/lib/experiments/configcat-server";
+import { TrustedValue } from "@gitpod/gitpod-protocol/lib/util/scrubbing";
 
 export interface StartWorkspaceOptions extends GitpodServer.StartWorkspaceOptions {
     excludeFeatureFlags?: NamedWorkspaceFeatureFlag[];
@@ -420,7 +421,9 @@ export class WorkspaceStarter {
             )
             .catch((err) => {
                 if (RedisMutex.isLockError(err)) {
-                    log.warn({ instanceId }, "unable to acquire lock for workspace instance start");
+                    log.warn({ instanceId }, "unable to acquire lock for workspace instance start", err, {
+                        a: new TrustedValue(err),
+                    });
                     return;
                 }
             });
@@ -582,9 +585,10 @@ export class WorkspaceStarter {
                 // due to the reconciliation loop we might have already started the workspace, especially in the "pending" phase
                 const workspaceAlreadyExists = await this.existsWithWsManager(ctx, instance);
                 if (workspaceAlreadyExists) {
-                    log.warn(
+                    log.debug(
                         { instanceId: instance.id, workspaceId: instance.workspaceId },
                         "workspace already exists, not starting again",
+                        { phase: instance.status.phase },
                     );
                     return;
                 }