Skip to content

Commit 5c90a1a

Browse files
authored
Improve workspace preview resource utilization (#18632)
* Improve workspace preview resource utilization * Fix deployment * Do not remove fluentbit
1 parent 063cfbe commit 5c90a1a

File tree

9 files changed

+2
-12156
lines changed

9 files changed

+2
-12156
lines changed

dev/preview/workflow/preview/deploy-gitpod.sh

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -131,19 +131,6 @@ EOF
131131
rm -f ${GITPOD_IMAGE_PULL_SECRET_NAME}
132132
}
133133

134-
function installRookCeph {
135-
diff-apply "${PREVIEW_K3S_KUBE_CONTEXT}" "$SCRIPT_PATH/../vm/manifests/rook-ceph/crds.yaml"
136-
137-
kubectl \
138-
--kubeconfig "${PREVIEW_K3S_KUBE_PATH}" \
139-
--context "${PREVIEW_K3S_KUBE_CONTEXT}" \
140-
wait --for condition=established --timeout=120s crd/cephclusters.ceph.rook.io
141-
142-
for file in common operator cluster-test storageclass-test snapshotclass;do
143-
diff-apply "${PREVIEW_K3S_KUBE_CONTEXT}" "$SCRIPT_PATH/../vm/manifests/rook-ceph/$file.yaml"
144-
done
145-
}
146-
147134
# Install Fluent-Bit sending logs to GCP
148135
function installFluentBit {
149136
kubectl \
@@ -175,7 +162,7 @@ function installFluentBit {
175162
helm3 \
176163
--kubeconfig "${PREVIEW_K3S_KUBE_PATH}" \
177164
--kube-context "${PREVIEW_K3S_KUBE_CONTEXT}" \
178-
upgrade --install fluent-bit fluent/fluent-bit --version 0.21.6 -n "${PREVIEW_NAMESPACE}" -f "$SCRIPT_PATH/../vm/charts/fluentbit/values.yaml"
165+
upgrade --install fluent-bit fluent/fluent-bit --version 0.37.1 -n "${PREVIEW_NAMESPACE}" -f "$SCRIPT_PATH/../vm/charts/fluentbit/values.yaml"
179166
}
180167

181168
# ====================================
@@ -198,7 +185,6 @@ while ! copyCachedCertificate; do
198185
done
199186

200187
copyImagePullSecret
201-
installRookCeph
202188
installFluentBit
203189

204190
# ========
@@ -589,7 +575,7 @@ rm -f "${INSTALLER_RENDER_PATH}"
589575
# =========================
590576
# Wait for objects to be ready
591577
# =========================
592-
for item in deployment.apps/blobserve deployment.apps/content-service deployment.apps/dashboard deployment.apps/ide-metrics deployment.apps/ide-proxy deployment.apps/ide-service deployment.apps/image-builder-mk3 deployment.apps/minio deployment.apps/node-labeler deployment.apps/proxy deployment.apps/public-api-server deployment.apps/redis deployment.apps/server deployment.apps/spicedb deployment.apps/usage deployment.apps/ws-manager-mk2 deployment.apps/ws-manager-bridge deployment.apps/ws-proxy statefulset.apps/mysql statefulset.apps/openvsx-proxy daemonset.apps/agent-smith daemonset.apps/fluent-bit daemonset.apps/registry-facade daemonset.apps/ws-daemon; do
578+
for item in deployment.apps/blobserve deployment.apps/content-service deployment.apps/dashboard deployment.apps/ide-metrics deployment.apps/ide-proxy deployment.apps/ide-service deployment.apps/image-builder-mk3 deployment.apps/minio deployment.apps/node-labeler deployment.apps/proxy deployment.apps/public-api-server deployment.apps/redis deployment.apps/server deployment.apps/spicedb deployment.apps/usage deployment.apps/ws-manager-mk2 deployment.apps/ws-manager-bridge deployment.apps/ws-proxy statefulset.apps/mysql statefulset.apps/openvsx-proxy daemonset.apps/agent-smith daemonset.apps/registry-facade daemonset.apps/ws-daemon; do
593579
kubectl --kubeconfig "${PREVIEW_K3S_KUBE_PATH}" --context "${PREVIEW_K3S_KUBE_CONTEXT}" rollout status "${item}" --namespace="${PREVIEW_NAMESPACE}"
594580
done
595581

dev/preview/workflow/preview/post-process.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -170,12 +170,6 @@ while [ "$documentIndex" -le "$DOCS" ]; do
170170
WS_URL_TEMP_EXPR="s|\"urlTemplate\": \"https://{{ .Prefix }}.$CURRENT_WS_HOST_NAME\"|\"urlTemplate\": \"https://{{ .Prefix }}.$NEW_WS_HOST_NAME\"|"
171171
sed -i "$WS_URL_TEMP_EXPR" /tmp/"$NAME"overrides.yaml
172172

173-
WS_SC_TEMP_EXPR="s|\"storageClass\": \"\"|\"storageClass\": \"rook-ceph-block\"|"
174-
sed -i "$WS_SC_TEMP_EXPR" /tmp/"$NAME"overrides.yaml
175-
176-
WS_SC_TEMP_EXPR="s|\"snapshotClass\": \"\"|\"snapshotClass\": \"csi-rbdplugin-snapclass\"|"
177-
sed -i "$WS_SC_TEMP_EXPR" /tmp/"$NAME"overrides.yaml
178-
179173
# Change the port we use to connect to registry-facade
180174
# is expected to be reg.<branch-name-with-dashes>.staging.gitpod-dev.com:$REG_DAEMON_PORT
181175
# Change the port we use to connect to ws-daemon

dev/preview/workflow/vm/charts/fluentbit/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ env:
88
- name: GOOGLE_SERVICE_CREDENTIALS
99
value: /gcp/credentials.json
1010

11-
1211
extraVolumes:
1312
- name: fluent-bit-external
1413
secret:

dev/preview/workflow/vm/manifests/rook-ceph/cluster-test.yaml

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)