Skip to content

Commit 5d22d4a

Browse files
jentingroboquat
authored andcommitted
Add a metric to record volume snapshot time
Signed-off-by: JenTing Hsiao <[email protected]>
1 parent 24031c6 commit 5d22d4a

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

components/ws-manager/pkg/manager/metrics.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,13 @@ const (
3737
type metrics struct {
3838
manager *Manager
3939

40-
startupTimeHistVec *prometheus.HistogramVec
41-
initializeTimeHistVec *prometheus.HistogramVec
42-
finalizeTimeHistVec *prometheus.HistogramVec
43-
totalStartsCounterVec *prometheus.CounterVec
44-
totalStopsCounterVec *prometheus.CounterVec
45-
totalOpenPortGauge prometheus.GaugeFunc
40+
startupTimeHistVec *prometheus.HistogramVec
41+
initializeTimeHistVec *prometheus.HistogramVec
42+
finalizeTimeHistVec *prometheus.HistogramVec
43+
volumeSnapshotTimeHistVec *prometheus.HistogramVec
44+
totalStartsCounterVec *prometheus.CounterVec
45+
totalStopsCounterVec *prometheus.CounterVec
46+
totalOpenPortGauge prometheus.GaugeFunc
4647

4748
mu sync.Mutex
4849
phaseState map[string]api.WorkspacePhase
@@ -74,6 +75,13 @@ func newMetrics(m *Manager) *metrics {
7475
Help: "time it took to finalize workspace",
7576
Buckets: prometheus.ExponentialBuckets(2, 2, 10),
7677
}, []string{"type"}),
78+
volumeSnapshotTimeHistVec: prometheus.NewHistogramVec(prometheus.HistogramOpts{
79+
Namespace: metricsNamespace,
80+
Subsystem: metricsWorkspaceSubsystem,
81+
Name: "volume_snapshot_seconds",
82+
Help: "time it took to snapshot volume",
83+
Buckets: prometheus.ExponentialBuckets(2, 2, 10),
84+
}, []string{"type"}),
7785
totalStartsCounterVec: prometheus.NewCounterVec(prometheus.CounterOpts{
7886
Namespace: metricsNamespace,
7987
Subsystem: metricsWorkspaceSubsystem,
@@ -136,6 +144,7 @@ func (m *metrics) Register(reg prometheus.Registerer) error {
136144
m.startupTimeHistVec,
137145
m.initializeTimeHistVec,
138146
m.finalizeTimeHistVec,
147+
m.volumeSnapshotTimeHistVec,
139148
newPhaseTotalVec(m.manager),
140149
newWorkspaceActivityVec(m.manager),
141150
newTimeoutSettingsVec(m.manager),

0 commit comments

Comments
 (0)