Skip to content

Commit 63e6625

Browse files
committed
1
1 parent a2f5e53 commit 63e6625

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

components/docker-up/docker-up/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ var aptUpdated = false
5959
const (
6060
dockerSocketFN = "/var/run/docker.sock"
6161
gitpodUserId = 33333
62-
containerIf = "eth0"
62+
containerIf = "ceth0"
6363
)
6464

6565
func main() {

components/ws-daemon/nsinsider/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ func main() {
275275
},
276276
},
277277
Action: func(c *cli.Context) error {
278-
containerIf, vethIf, cethIf := "eth0", "veth0", "eth0"
278+
containerIf, vethIf, cethIf := "eth0", "veth0", "ceth0"
279279
networkCIDR := c.String("workspace-cidr")
280280

281281
vethIp, cethIp, mask, err := processWorkspaceCIDR(networkCIDR)
@@ -337,7 +337,7 @@ func main() {
337337
Table: nat,
338338
Chain: postrouting,
339339
Exprs: []expr.Any{
340-
&expr.Meta{Key: expr.MetaKeyIIFNAME, Register: 1},
340+
&expr.Meta{Key: expr.MetaKeyOIFNAME, Register: 1},
341341
&expr.Cmp{
342342
Op: expr.CmpOpEq,
343343
Register: 1,
@@ -420,7 +420,7 @@ func main() {
420420
},
421421
},
422422
Action: func(c *cli.Context) error {
423-
cethIf := "eth0"
423+
cethIf := "ceth0"
424424

425425
networkCIDR := c.String("workspace-cidr")
426426
vethIp, cethIp, mask, err := processWorkspaceCIDR(networkCIDR)

install/installer/pkg/cluster/checks.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ func CheckWorkspaceCIDR(networkCIDR string) ValidationCheck {
299299
Name: "workspace CIDR is present and valid",
300300
Description: "ensures the workspace CIDR contains a valid network address range",
301301
Check: func(ctx context.Context, config *rest.Config, namespace string) ([]ValidationError, error) {
302-
netIP, _, err := net.ParseCIDR(networkCIDR)
302+
netIP, ipNet, err := net.ParseCIDR(networkCIDR)
303303
if err != nil {
304304
return []ValidationError{
305305
{
@@ -309,6 +309,17 @@ func CheckWorkspaceCIDR(networkCIDR string) ValidationCheck {
309309
}, nil
310310
}
311311

312+
ipNet.Mask.Size()
313+
mask, _ := ipNet.Mask.Size()
314+
if mask > 30 {
315+
return []ValidationError{
316+
{
317+
Message: "the workspace CIDR does not have a mask less than or equal to /30",
318+
Type: ValidationStatusError,
319+
},
320+
}, nil
321+
}
322+
312323
addr, err := netip.ParseAddr(netIP.String())
313324
if err != nil {
314325
return []ValidationError{

0 commit comments

Comments
 (0)