feedback

Author: mustard-mh

components/dashboard/src/service/public-api.ts

@@ -45,6 +45,9 @@ export const oidcService = createPromiseClient(OIDCService, transport);
 export const workspaceClient = createServiceClient(WorkspaceService, new JsonRpcWorkspaceClient());
 export const organizationClient = createServiceClient(OrganizationService, new JsonRpcOrganizationClient());
 
+// @ts-ignore
+window.$localTest = workspaceClient;
+
 export function publicApiTeamToProtocol(team: Team): ProtocolTeam {
     return {
         id: team.id,

components/gitpod-protocol/src/generate-async-generator.ts

@@ -53,7 +53,8 @@ export async function* generateAsyncGenerator<T>(
                 });
             }
         }
-    } catch (e) {
+        // ignore error since code in `try` scope will not throw an error
+        // unless caller use it.throw, then it will throw to itself
     } finally {
         cleanup();
     }

components/public-api/gitpod/experimental/v2/workspace.proto

@@ -13,26 +13,26 @@ service WorkspaceService {
   // ID +return NOT_FOUND Workspace does not exist
   rpc GetWorkspace(GetWorkspaceRequest) returns (GetWorkspaceResponse) {}
 
-  // WatchWorkspace watchs the workspace status changes
+  // WatchWorkspaceStatus watchs the workspaces status changes
   //
   // ID +return NOT_FOUND Workspace does not exist
-  rpc WatchWorkspace(WatchWorkspaceRequest) returns (stream WatchWorkspaceResponse) {}
+  rpc WatchWorkspaceStatus(WatchWorkspaceStatusRequest) returns (stream WatchWorkspaceStatusResponse) {}
 }
 
 message GetWorkspaceRequest { string id = 1; }
 
 message GetWorkspaceResponse { Workspace item = 1; }
 
-message WatchWorkspaceRequest {
-  // id specifies the workspace to watch
+message WatchWorkspaceStatusRequest {
+  // workspace_id specifies the workspace to watch
   //
   // +optional if empty then watch all workspaces
-  optional string id = 1;
+  optional string workspace_id = 1;
 }
 
-message WatchWorkspaceResponse {
+message WatchWorkspaceStatusResponse {
   // item is the workspace that was changed
-  Workspace item = 1;
+  Workspace workspace = 1;
 }
 
 // +resource get workspace