Skip to content

Commit 711bd6e

Browse files
committed
return updated provider in UpdateAuthProviderResponse
1 parent 2e482e1 commit 711bd6e

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

components/dashboard/src/service/json-rpc-authprovider-client.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,13 @@ export class JsonRpcAuthProviderClient implements PromiseClient<typeof AuthProvi
119119
throw new ConnectError("clientId or clientSecret are required", Code.InvalidArgument);
120120
}
121121

122-
await getGitpodService().server.updateAuthProvider(request.authProviderId, {
122+
const entry = await getGitpodService().server.updateAuthProvider(request.authProviderId, {
123123
clientId,
124124
clientSecret,
125125
});
126-
return new UpdateAuthProviderResponse();
126+
return new UpdateAuthProviderResponse({
127+
authProvider: converter.toAuthProvider(entry),
128+
});
127129
}
128130

129131
async deleteAuthProvider(request: PartialMessage<DeleteAuthProviderRequest>): Promise<DeleteAuthProviderResponse> {

components/server/src/api/auth-provider-service-api.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,23 +143,26 @@ export class AuthProviderServiceAPI implements ServiceImpl<typeof AuthProviderSe
143143
throw new ConnectError("Provider not found.", Code.NotFound);
144144
}
145145

146+
let entry: AuthProviderEntry;
146147
if (authProvider.organizationId) {
147-
await this.authProviderService.updateOrgAuthProvider(context.user.id, {
148+
entry = await this.authProviderService.updateOrgAuthProvider(context.user.id, {
148149
id: request.authProviderId,
149150
organizationId: authProvider.organizationId,
150151
clientId: clientId,
151152
clientSecret: clientSecret,
152153
});
153154
} else {
154-
await this.authProviderService.updateAuthProviderOfUser(context.user.id, {
155+
entry = await this.authProviderService.updateAuthProviderOfUser(context.user.id, {
155156
id: request.authProviderId,
156157
ownerId: context.user.id,
157158
clientId: clientId,
158159
clientSecret: clientSecret,
159160
});
160161
}
161162

162-
return new UpdateAuthProviderResponse();
163+
return new UpdateAuthProviderResponse({
164+
authProvider: this.apiConverter.toAuthProvider(AuthProviderEntry.redact(entry)),
165+
});
163166
}
164167

165168
async deleteAuthProvider(

0 commit comments

Comments
 (0)