[server] move "not-deleted" check into WorkspaceService.startWorkspace

Author: geropl

components/server/src/workspace/gitpod-server-impl.ts

@@ -928,9 +928,6 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable {
             };
         }
 
-        if (!!workspace.softDeleted) {
-            throw new ApplicationError(ErrorCodes.NOT_FOUND, "Workspace not found!");
-        }
         // (gpl) We keep this check here for backwards compatibility, it should be superfluous in the future
         // no matter if the workspace is shared or not, you cannot create a new instance
         await this.guardAccess({ kind: "workspaceInstance", subject: undefined, workspace }, "create");

components/server/src/workspace/workspace-service.ts

@@ -259,6 +259,10 @@ export class WorkspaceService {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "Cannot (re-)start irregular workspace.");
         }
 
+        if (!!workspace.softDeleted) {
+            throw new ApplicationError(ErrorCodes.NOT_FOUND, "Workspace not found!");
+        }
+
         const envVarsPromise = this.envVarService.resolve(workspace);
         const projectPromise = workspace.projectId
             ? ApplicationError.notFoundToUndefined(this.projectsService.getProject(user.id, workspace.projectId))