Skip to content

Commit 7664094

Browse files
committed
fixup fromWorkspaceAutostartOption
1 parent fa5d001 commit 7664094

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

components/public-api/typescript-common/src/public-api-converter.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* See License.AGPL.txt in the project root for license information.
55
*/
66

7+
import "reflect-metadata";
8+
79
import { Timestamp, toPlainMessage, PartialMessage, Duration } from "@bufbuild/protobuf";
810
import { Code, ConnectError } from "@connectrpc/connect";
911
import {
@@ -135,6 +137,7 @@ import type { DeepPartial } from "@gitpod/gitpod-protocol/lib/util/deep-partial"
135137
import { BlockedRepository as ProtocolBlockedRepository } from "@gitpod/gitpod-protocol/lib/blocked-repositories-protocol";
136138
import { RoleOrPermission } from "@gitpod/gitpod-protocol/lib/permission";
137139
import { parseGoDurationToMs } from "@gitpod/gitpod-protocol/lib/util/timeutil";
140+
import { isWorkspaceRegion } from "@gitpod/gitpod-protocol/lib/workspace-cluster";
138141

139142
export type PartialConfiguration = DeepPartial<Configuration> & Pick<Configuration, "id">;
140143

@@ -1228,7 +1231,7 @@ export class PublicAPIConverter {
12281231
if (!e) {
12291232
return undefined;
12301233
}
1231-
return <IDESettings>{
1234+
return {
12321235
defaultIde: e.name,
12331236
useLatestVersion: e.version === "latest",
12341237
};
@@ -1245,11 +1248,12 @@ export class PublicAPIConverter {
12451248
}
12461249

12471250
fromWorkspaceAutostartOption(o: User_WorkspaceAutostartOption): WorkspaceAutostartOption {
1248-
return <WorkspaceAutostartOption>{
1251+
const region = isWorkspaceRegion(o.region) ? o.region : "";
1252+
return {
12491253
cloneURL: o.cloneUrl,
1250-
editorSettings: this.fromEditorReference(o.editorSettings),
1254+
ideSettings: this.fromEditorReference(o.editorSettings),
12511255
organizationId: o.organizationId,
1252-
region: o.region,
1256+
region,
12531257
workspaceClass: o.workspaceClass,
12541258
};
12551259
}

components/server/src/user/user-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { CreateUserParams } from "./user-authentication";
2424
import { IAnalyticsWriter } from "@gitpod/gitpod-protocol/lib/analytics";
2525
import { TransactionalContext } from "@gitpod/gitpod-db/lib/typeorm/transactional-db-impl";
2626
import { RelationshipUpdater } from "../authorization/relationship-updater";
27-
import { getProfile } from "@gitpod/public-api-common/src/user-utils";
27+
import { getProfile } from "@gitpod/public-api-common/lib/user-utils";
2828

2929
@injectable()
3030
export class UserService {

0 commit comments

Comments
 (0)