Skip to content

Commit 77fb92c

Browse files
committed
[db] DBGitpodToken: Switch to sync deletion
1 parent 4d60bfa commit 77fb92c

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

components/gitpod-db/src/typeorm/user-db-impl.ts

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import {
2929
OAuthUser,
3030
} from "@jmondi/oauth2-server";
3131
import { inject, injectable, optional } from "inversify";
32-
import { EntityManager, Equal, Not, Repository } from "typeorm";
32+
import { EntityManager, Equal, FindOperator, Not, Repository } from "typeorm";
3333
import { v4 as uuidv4 } from "uuid";
3434
import {
3535
BUILTIN_WORKSPACE_PROBE_USER_ID,
@@ -256,27 +256,12 @@ export class TypeORMUserDBImpl extends TransactionalDBImpl<UserDB> implements Us
256256

257257
public async deleteGitpodToken(tokenHash: string): Promise<void> {
258258
const repo = await this.getGitpodTokenRepo();
259-
await repo.query(
260-
`
261-
UPDATE d_b_gitpod_token AS gt
262-
SET gt.deleted = TRUE
263-
WHERE tokenHash = ?;
264-
`,
265-
[tokenHash],
266-
);
259+
await repo.delete({ tokenHash });
267260
}
268261

269262
public async deleteGitpodTokensNamedLike(userId: string, namePattern: string): Promise<void> {
270263
const repo = await this.getGitpodTokenRepo();
271-
await repo.query(
272-
`
273-
UPDATE d_b_gitpod_token AS gt
274-
SET gt.deleted = TRUE
275-
WHERE userId = ?
276-
AND name LIKE ?
277-
`,
278-
[userId, namePattern],
279-
);
264+
await repo.delete({ userId, name: new FindOperator("like", namePattern) });
280265
}
281266

282267
public async storeSingleToken(identity: Identity, token: Token): Promise<TokenEntry> {

0 commit comments

Comments
 (0)