Skip to content

Commit 7e28c3a

Browse files
committed
Add EnableAdditionalECRAuth to Gitpod config
1 parent e7feb0f commit 7e28c3a

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

components/image-builder-api/go/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type Configuration struct {
4545
// EnableAdditionalECRAuth adds additional ECR auth using IRSA.
4646
// This will attempt to add ECR auth for any ECR repo a user is
4747
// trying to access.
48-
EnableAdditionalECRAuth bool
48+
EnableAdditionalECRAuth bool `json:"enableAdditionalECRAuth"`
4949
}
5050

5151
type TLS struct {

install/installer/pkg/components/image-builder-mk3/configmap.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
5555
BaseImageRepository: fmt.Sprintf("%s/base-images", registryName),
5656
BuilderImage: ctx.ImageName(ctx.Config.Repository, BuilderImage, ctx.VersionManifest.Components.ImageBuilderMk3.BuilderImage.Version),
5757
WorkspaceImageRepository: fmt.Sprintf("%s/workspace-images", registryName),
58+
EnableAdditionalECRAuth: ctx.Config.ContainerRegistry.EnableAdditionalECRAuth,
5859
}
5960

6061
workspaceImage := ctx.Config.Workspace.WorkspaceImage

install/installer/pkg/config/v1/config.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,10 +258,12 @@ const (
258258
)
259259

260260
type ContainerRegistry struct {
261-
InCluster *bool `json:"inCluster,omitempty" validate:"required"`
262-
External *ContainerRegistryExternal `json:"external,omitempty" validate:"required_if=InCluster false"`
263-
S3Storage *S3Storage `json:"s3storage,omitempty"`
264-
PrivateBaseImageAllowList []string `json:"privateBaseImageAllowList"`
261+
InCluster *bool `json:"inCluster,omitempty" validate:"required"`
262+
External *ContainerRegistryExternal `json:"external,omitempty" validate:"required_if=InCluster false"`
263+
S3Storage *S3Storage `json:"s3storage,omitempty"`
264+
265+
PrivateBaseImageAllowList []string `json:"privateBaseImageAllowList"`
266+
EnableAdditionalECRAuth bool `json:"enableAdditionalECRAuth"`
265267
}
266268

267269
type ContainerRegistryExternal struct {

0 commit comments

Comments
 (0)