Skip to content

Commit 81c22d5

Browse files
committed
Revert dashboard changes
1 parent 66d815f commit 81c22d5

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

components/dashboard/src/components/SelectIDEComponent.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
*/
66

77
import { IDEOption, IDEOptions } from "@gitpod/gitpod-protocol/lib/ide-protocol";
8-
import { useCallback, useContext, useEffect, useState } from "react";
8+
import { useCallback, useEffect, useState } from "react";
99
import { getGitpodService } from "../service/service";
1010
import { DropDown2, DropDown2Element } from "./DropDown2";
1111
import Editor from "../icons/Editor.svg";
12-
import { FeatureFlagContext } from "../contexts/FeatureFlagContext";
1312

1413
interface SelectIDEComponentProps {
1514
selectedIdeOption?: string;
@@ -18,16 +17,8 @@ interface SelectIDEComponentProps {
1817
setError?: (error?: string) => void;
1918
}
2019

21-
function filteredIdeOptions(ideOptions: IDEOptions, experimentalTurnedOn: boolean) {
22-
return IDEOptions.asArray(ideOptions)
23-
.filter((x) => !x.hidden)
24-
.filter((x) => (x.experimental ? experimentalTurnedOn : true));
25-
}
26-
2720
export default function SelectIDEComponent(props: SelectIDEComponentProps) {
2821
const [ideOptions, setIdeOptions] = useState<IDEOptions>();
29-
const { experimentalIdes } = useContext(FeatureFlagContext);
30-
3122
useEffect(() => {
3223
getGitpodService().server.getIDEOptions().then(setIdeOptions);
3324
}, []);
@@ -36,7 +27,7 @@ export default function SelectIDEComponent(props: SelectIDEComponentProps) {
3627
if (!ideOptions) {
3728
return [];
3829
}
39-
const options = filteredIdeOptions(ideOptions, experimentalIdes);
30+
const options = IDEOptions.asArray(ideOptions);
4031
const result: DropDown2Element[] = [];
4132
for (const ide of options.filter((ide) =>
4233
`${ide.label}${ide.title}${ide.notes}${ide.id}`.toLowerCase().includes(search.toLowerCase()),

components/dashboard/src/contexts/FeatureFlagContext.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ const defaultFeatureFlags = {
3131
userGitAuthProviders: false,
3232
newSignupFlow: false,
3333
linkedinConnectionForOnboarding: false,
34-
experimentalIdes: false,
3534
};
3635

3736
const FeatureFlagContext = createContext<FeatureFlagsType>(defaultFeatureFlags);
@@ -52,7 +51,6 @@ const FeatureFlagContextProvider: React.FC = ({ children }) => {
5251
const [userGitAuthProviders, setUserGitAuthProviders] = useState<boolean>(false);
5352
const [newSignupFlow, setNewSignupFlow] = useState<boolean>(false);
5453
const [linkedinConnectionForOnboarding, setLinkedinConnectionForOnboarding] = useState<boolean>(false);
55-
const [experimentalIdes, setExperimentalIdes] = useState<boolean>(false);
5654

5755
useEffect(() => {
5856
if (!user) return;
@@ -73,7 +71,6 @@ const FeatureFlagContextProvider: React.FC = ({ children }) => {
7371
userGitAuthProviders: { defaultValue: false, setter: setUserGitAuthProviders },
7472
newSignupFlow: { defaultValue: false, setter: setNewSignupFlow },
7573
linkedinConnectionForOnboarding: { defaultValue: false, setter: setLinkedinConnectionForOnboarding },
76-
experimentalIdes: { defaultValue: false, setter: setExperimentalIdes },
7774
};
7875

7976
for (const [flagName, config] of Object.entries(featureFlags)) {
@@ -123,7 +120,6 @@ const FeatureFlagContextProvider: React.FC = ({ children }) => {
123120
userGitAuthProviders,
124121
newSignupFlow,
125122
linkedinConnectionForOnboarding,
126-
experimentalIdes,
127123
};
128124
}, [
129125
enablePersonalAccessTokens,
@@ -137,7 +133,6 @@ const FeatureFlagContextProvider: React.FC = ({ children }) => {
137133
startWithOptions,
138134
usePublicApiWorkspacesService,
139135
userGitAuthProviders,
140-
experimentalIdes,
141136
]);
142137

143138
return <FeatureFlagContext.Provider value={flags}>{children}</FeatureFlagContext.Provider>;

0 commit comments

Comments
 (0)