Skip to content

Commit 84a353b

Browse files
committed
Revert "Update Platform Version of JetBrains Gateway Plugin (Stable) to 232.8660-EAP-CANDIDATE-SNAPSHOT (#18368)"
This reverts commit fb7784f.
1 parent 3e1f1b7 commit 84a353b

File tree

7 files changed

+94
-10
lines changed

7 files changed

+94
-10
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
22
# for insight into build numbers and IntelliJ Platform versions.
3-
pluginSinceBuild=232.8660
4-
pluginUntilBuild=232.*
3+
pluginSinceBuild=231.9161
4+
pluginUntilBuild=231.*
55
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
66
# See https://jb.gg/intellij-platform-builds-list for available build versions.
7-
pluginVerifierIdeVersions=2023.2
7+
pluginVerifierIdeVersions=2023.1
88
# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
9-
platformVersion=232.8660-EAP-CANDIDATE-SNAPSHOT
9+
platformVersion=231.9161-EAP-CANDIDATE-SNAPSHOT

components/ide/jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import com.jetbrains.rd.util.URI
4343
import com.jetbrains.rd.util.lifetime.Lifetime
4444
import com.jetbrains.rd.util.lifetime.LifetimeDefinition
4545
import io.gitpod.gitpodprotocol.api.entities.WorkspaceInstance
46+
import io.gitpod.jetbrains.gateway.common.GitpodConnectionHandleFactory
4647
import io.gitpod.jetbrains.icons.GitpodIcons
4748
import kotlinx.coroutines.*
4849
import java.net.URL
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// Copyright (c) 2023 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License.AGPL.txt in the project root for license information.
4+
5+
package io.gitpod.jetbrains.gateway.common
6+
7+
import com.jetbrains.gateway.api.GatewayConnectionHandle
8+
import com.jetbrains.rd.util.lifetime.Lifetime
9+
import io.gitpod.jetbrains.gateway.GitpodConnectionProvider
10+
import javax.swing.JComponent
11+
12+
@Suppress("UnstableApiUsage")
13+
interface GitpodConnectionHandleFactory {
14+
fun createGitpodConnectionHandle(
15+
lifetime: Lifetime,
16+
component: JComponent,
17+
params: GitpodConnectionProvider.ConnectParams
18+
): GatewayConnectionHandle
19+
20+
suspend fun connect(
21+
lifetime: Lifetime,
22+
connector: com.jetbrains.gateway.ssh.HostTunnelConnector,
23+
tcpJoinLink: java.net.URI
24+
): com.jetbrains.gateway.thinClientLink.ThinClientHandle
25+
}
Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
// Licensed under the GNU Affero General Public License (AGPL).
33
// See License.AGPL.txt in the project root for license information.
44

5-
package io.gitpod.jetbrains.gateway
5+
package io.gitpod.jetbrains.gateway.latest
66

7-
import com.intellij.openapi.components.Service
87
import com.jetbrains.gateway.api.CustomConnectionFrameComponentProvider
98
import com.jetbrains.gateway.api.CustomConnectionFrameContext
109
import com.jetbrains.gateway.api.GatewayConnectionHandle
@@ -13,6 +12,7 @@ import com.jetbrains.gateway.ssh.HostTunnelConnector
1312
import com.jetbrains.gateway.thinClientLink.ThinClientHandle
1413
import com.jetbrains.rd.util.lifetime.Lifetime
1514
import io.gitpod.jetbrains.gateway.GitpodConnectionProvider.ConnectParams
15+
import io.gitpod.jetbrains.gateway.common.GitpodConnectionHandleFactory
1616
import java.net.URI
1717
import javax.swing.JComponent
1818

@@ -35,17 +35,16 @@ class GitpodConnectionHandle(
3535
}
3636
}
3737
@Suppress("UnstableApiUsage")
38-
@Service
39-
class GitpodConnectionHandleFactory {
40-
fun createGitpodConnectionHandle(
38+
class LatestGitpodConnectionHandleFactory : GitpodConnectionHandleFactory {
39+
override fun createGitpodConnectionHandle(
4140
lifetime: Lifetime,
4241
component: JComponent,
4342
params: ConnectParams
4443
): GatewayConnectionHandle {
4544
return GitpodConnectionHandle(lifetime, component, params)
4645
}
4746

48-
suspend fun connect(lifetime: Lifetime, connector: HostTunnelConnector, tcpJoinLink: URI): ThinClientHandle {
47+
override suspend fun connect(lifetime: Lifetime, connector: HostTunnelConnector, tcpJoinLink: URI): ThinClientHandle {
4948
return ClientOverSshTunnelConnector(
5049
lifetime,
5150
connector
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
// Copyright (c) 2023 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License.AGPL.txt in the project root for license information.
4+
5+
package io.gitpod.jetbrains.gateway.stable
6+
7+
import com.jetbrains.gateway.api.CustomConnectionFrameComponentProvider
8+
import com.jetbrains.gateway.api.CustomConnectionFrameContext
9+
import com.jetbrains.gateway.api.GatewayConnectionHandle
10+
import com.jetbrains.gateway.ssh.ClientOverSshTunnelConnector
11+
import com.jetbrains.gateway.ssh.HostTunnelConnector
12+
import com.jetbrains.gateway.thinClientLink.ThinClientHandle
13+
import com.jetbrains.rd.util.lifetime.Lifetime
14+
import io.gitpod.jetbrains.gateway.GitpodConnectionProvider.ConnectParams
15+
import io.gitpod.jetbrains.gateway.common.GitpodConnectionHandleFactory
16+
import java.net.URI
17+
import javax.swing.JComponent
18+
19+
class GitpodConnectionHandle(
20+
lifetime: Lifetime,
21+
private val component: JComponent,
22+
private val params: ConnectParams
23+
) : GatewayConnectionHandle(lifetime) {
24+
override fun customComponentProvider() = object : CustomConnectionFrameComponentProvider {
25+
override val closeConfirmationText = "Disconnect from ${getTitle()}?"
26+
override fun createComponent(context: CustomConnectionFrameContext) = component
27+
}
28+
29+
override fun getTitle(): String {
30+
return params.title
31+
}
32+
33+
override fun hideToTrayOnStart(): Boolean {
34+
return false
35+
}
36+
}
37+
38+
@Suppress("UnstableApiUsage")
39+
class StableGitpodConnectionHandleFactory : GitpodConnectionHandleFactory {
40+
override fun createGitpodConnectionHandle(
41+
lifetime: Lifetime,
42+
component: JComponent,
43+
params: ConnectParams
44+
): GatewayConnectionHandle {
45+
return GitpodConnectionHandle(lifetime, component, params)
46+
}
47+
48+
override suspend fun connect(lifetime: Lifetime, connector: HostTunnelConnector, tcpJoinLink: URI): ThinClientHandle {
49+
return ClientOverSshTunnelConnector(
50+
lifetime,
51+
connector,
52+
tcpJoinLink
53+
).connect()
54+
}
55+
}

components/ide/jetbrains/gateway-plugin/src/main/resources-latest/META-INF/extensions.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
-->
66
<idea-plugin>
77
<extensions defaultExtensionNs="com.intellij">
8+
<applicationService serviceInterface="io.gitpod.jetbrains.gateway.common.GitpodConnectionHandleFactory"
9+
serviceImplementation="io.gitpod.jetbrains.gateway.latest.LatestGitpodConnectionHandleFactory"/>
810
</extensions>
911
<extensions defaultExtensionNs="com.jetbrains">
1012
</extensions>

components/ide/jetbrains/gateway-plugin/src/main/resources-stable/META-INF/extensions.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
-->
66
<idea-plugin>
77
<extensions defaultExtensionNs="com.intellij">
8+
<applicationService serviceInterface="io.gitpod.jetbrains.gateway.common.GitpodConnectionHandleFactory"
9+
serviceImplementation="io.gitpod.jetbrains.gateway.stable.StableGitpodConnectionHandleFactory"/>
810
</extensions>
911
<extensions defaultExtensionNs="com.jetbrains">
1012
</extensions>

0 commit comments

Comments
 (0)