Skip to content

Commit 8683749

Browse files
committed
fixup! [api] Expose session.Metrics.InitializerMetrics
Tool: gitpod/catfood.gitpod.cloud
1 parent faf69e7 commit 8683749

File tree

4 files changed

+180
-18
lines changed

4 files changed

+180
-18
lines changed

components/public-api/gitpod/v1/workspace.proto

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ message WorkspaceSession {
946946

947947
// Add these new message definitions
948948
message InitializerMetric {
949-
// Duration in nanoseconds (standard protobuf duration)
949+
// Duration in seconds
950950
google.protobuf.Duration duration = 1;
951951

952952
// Size in bytes
@@ -955,22 +955,31 @@ message WorkspaceSession {
955955

956956
message InitializerMetrics {
957957
// Git contains metrics for the git initializer step
958+
// This is set whenenver a `git clone` is issued (mostly on first workspace start)
958959
InitializerMetric git = 1;
959960

960961
// FileDownload contains metrics for the file download initializer step
962+
// This is set for injecting "additionalFiles" into the workspace.
961963
InitializerMetric file_download = 2;
962964

963965
// Snapshot contains metrics for the snapshot initializer step
964966
// This used for workspaces started from snapshots.
965967
InitializerMetric snapshot = 3;
966968

967969
// Backup contains metrics for the backup initializer step
970+
// This is set on subsequent workspace starts, when the file system is restored from backup.
968971
InitializerMetric backup = 4;
969972

970973
// Prebuild contains metrics for the prebuild initializer step
974+
// This is set if the workspace is based on a prebuild.
971975
InitializerMetric prebuild = 5;
972976

973977
// Composite contains metrics for the composite initializer step
978+
// This reports the total if multiple steps are run to initialize the workspace content.
979+
// Examples are:
980+
// - "additionalFiles" injected into the workspace
981+
// - "additionalRepositories" configured
982+
// - incremental Prebuilds
974983
InitializerMetric composite = 6;
975984
}
976985

components/public-api/go/v1/workspace.pb.go

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)