rename updateUserIdForExperiments

Author: AlexTugarev

components/dashboard/src/service/public-api.ts

@@ -42,7 +42,6 @@ import { VerificationService } from "@gitpod/public-api/lib/gitpod/v1/verificati
 import { JsonRpcInstallationClient } from "./json-rpc-installation-client";
 import { InstallationService } from "@gitpod/public-api/lib/gitpod/v1/installation_connect";
 import { JsonRpcUserClient } from "./json-rpc-user-client";
-import { User } from "@gitpod/public-api/lib/gitpod/v1/user_pb";
 
 const transport = createConnectTransport({
     baseUrl: `${window.location.protocol}//${window.location.host}/public-api`,
@@ -164,9 +163,9 @@ export function projectToProtocol(project: Project): ProtocolProject {
     };
 }
 
-let user: User | undefined;
-export function updateUser(newUser: User | undefined) {
-    user = newUser;
+let userId: string | undefined;
+export function updateUserIdForExperiments(newUserId: string | undefined) {
+    userId = newUserId;
 }
 
 function createServiceClient<T extends ServiceType>(
@@ -191,7 +190,7 @@ function createServiceClient<T extends ServiceType>(
                 const resolvedFlags = await Promise.all(
                     featureFlags.map((ff) =>
                         experimentsClient.getValueAsync(ff, false, {
-                            user: { id: user?.id || "" },
+                            user: { id: userId || "" },
                             gitpodHost: window.location.host,
                         }),
                     ),

components/dashboard/src/user-context.tsx

@@ -7,7 +7,7 @@
 import { useQueryClient } from "@tanstack/react-query";
 import React, { createContext, useState, useMemo, useCallback } from "react";
 import { updateCommonErrorDetails } from "./service/metrics";
-import { updateUser } from "./service/public-api";
+import { updateUserIdForExperiments } from "./service/public-api";
 import { User } from "@gitpod/public-api/lib/gitpod/v1/user_pb";
 
 const UserContext = createContext<{
@@ -23,7 +23,7 @@ const UserContextProvider: React.FC = ({ children }) => {
 
     const updateServiceUser = (user?: User) => {
         updateCommonErrorDetails({ userId: user?.id });
-        updateUser(user);
+        updateUserIdForExperiments(user?.id);
     };
     updateServiceUser(user);