Skip to content

Commit 98be901

Browse files
committed
Cleanup
1 parent 34ab82f commit 98be901

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed

test/go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ require (
2020
github.com/prometheus/procfs v0.10.1
2121
github.com/vishvananda/netns v0.0.4
2222
golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
23-
golang.org/x/oauth2 v0.6.0
23+
golang.org/x/oauth2 v0.8.0
2424
golang.org/x/sync v0.2.0
2525
golang.org/x/sys v0.11.0
2626
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
@@ -32,7 +32,7 @@ require (
3232
k8s.io/client-go v0.27.3
3333
k8s.io/klog/v2 v2.90.1
3434
k8s.io/kubectl v0.27.3
35-
sigs.k8s.io/e2e-framework v0.0.7
35+
sigs.k8s.io/e2e-framework v0.2.0
3636
)
3737

3838
require (
@@ -156,7 +156,7 @@ require (
156156
go.opencensus.io v0.24.0 // indirect
157157
go.starlark.net v0.0.0-20200306205701-8dd3e2ee1dd5 // indirect
158158
go.uber.org/atomic v1.8.0 // indirect
159-
golang.org/x/crypto v0.1.0 // indirect
159+
golang.org/x/crypto v0.7.0 // indirect
160160
golang.org/x/mod v0.10.0 // indirect
161161
golang.org/x/net v0.10.0 // indirect
162162
golang.org/x/term v0.8.0 // indirect

test/go.sum

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/run.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,17 @@ if [ "$TEST_SUITE" == "workspace" ]; then
114114

115115
set +e
116116
# shellcheck disable=SC2086
117-
go test -p 6 -v $TEST_LIST "${args[@]}" -parallel-features=true 2>&1 | go-junit-report -subtest-mode=exclude-parents -set-exit-code -out "${RESULTS_DIR}/TEST-${TEST_NAME}.xml" -iocopy
117+
go test -p 6 -v $TEST_LIST "${args[@]}" -parallel-features=true -skip-labels="type=maintenance" 2>&1 | go-junit-report -subtest-mode=exclude-parents -set-exit-code -out "${RESULTS_DIR}/TEST-${TEST_NAME}.xml" -iocopy
118118
RC=${PIPESTATUS[0]}
119119
set -e
120120

121121
if [ "${RC}" -ne "0" ]; then
122122
FAILURE_COUNT=$((FAILURE_COUNT+1))
123123
fi
124124

125+
# shellcheck disable=SC2086
126+
go test -v $TEST_LIST "${args[@]}" -labels="type=maintenance" -parallel-features=false 2>&1
127+
125128
cd -
126129
if [ "${REPORT}" != "" ]; then
127130
"${THIS_DIR}/report.sh" "${LOG_FILE}" > "$REPORT"

test/tests/components/ws-manager/maintenence_test.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func TestMaintenance(t *testing.T) {
2929
testRepo := "https://github.com/gitpod-io/empty"
3030
testRepoName := "empty"
3131

32-
f := features.New("ws-manager").
32+
f1 := features.New("maintenance").
3333
WithLabel("component", "ws-manager").
3434
WithLabel("type", "maintenance").
3535
Assess("should display maintenance message", func(testCtx context.Context, t *testing.T, cfg *envconf.Config) context.Context {
@@ -97,14 +97,7 @@ func TestMaintenance(t *testing.T) {
9797
}).
9898
Feature()
9999

100-
testEnv.Test(t, f)
101-
}
102-
103-
func TestMaintenanceUpdate(t *testing.T) {
104-
testRepo := "https://github.com/gitpod-io/empty"
105-
testRepoName := "empty"
106-
107-
f := features.New("ws-manager").
100+
f2 := features.New("maintenance-configuration").
108101
WithLabel("component", "ws-manager").
109102
WithLabel("type", "maintenance").
110103
Assess("should display a maintenance message when configured and not when disabled", func(testCtx context.Context, t *testing.T, cfg *envconf.Config) context.Context {
@@ -195,8 +188,9 @@ func TestMaintenanceUpdate(t *testing.T) {
195188
}).
196189
Feature()
197190

198-
testEnv.Test(t, f)
191+
testEnv.Test(t, f1, f2)
199192
}
193+
200194
func maintenanceConfigmap(untilTime *time.Time) (*corev1.ConfigMap, error) {
201195
mcfg := config.MaintenanceConfig{}
202196
if untilTime != nil {

0 commit comments

Comments
 (0)