[dashboard] unify error reporting

move error boundary to general error reporting endpoint as well

Author: akosyakov

components/dashboard/src/components/error-boundaries/ReloadPageErrorBoundary.tsx

@@ -5,10 +5,10 @@
  */
 
 import { FC, useCallback } from "react";
-import { ErrorBoundary, FallbackProps, ErrorBoundaryProps } from "react-error-boundary";
+import { ErrorBoundary, ErrorBoundaryProps, FallbackProps } from "react-error-boundary";
 import gitpodIcon from "../../icons/gitpod.svg";
-import { getGitpodService } from "../../service/service";
 import { Heading1, Subheading } from "../typography/headings";
+import { reportError } from "../../service/metrics";
 
 export type CaughtError = Error & { code?: number };
 
@@ -64,11 +64,4 @@ export const ReloadPageErrorFallback: FC<Pick<FallbackProps, "error">> = ({ erro
     );
 };
 
-export const handleError: ErrorBoundaryProps["onError"] = async (error, info) => {
-    const url = window.location.toString();
-    try {
-        await getGitpodService().server.reportErrorBoundary(url, error.message || "Unknown Error");
-    } catch (e) {
-        console.error(e);
-    }
-};
+export const handleError: ErrorBoundaryProps["onError"] = (error, info) => reportError("Error boundary", error, info);

components/dashboard/src/service/metrics.ts

@@ -40,7 +40,7 @@ console.error = function (...args) {
     reportError(...args);
 };
 
-function reportError(...args: any[]) {
+export function reportError(...args: any[]) {
     let err = undefined;
     let details = undefined;
     if (args[0] instanceof Error) {
@@ -61,7 +61,7 @@ function reportError(...args: any[]) {
         }
     }
 
-    let data = undefined;
+    let data = {};
     if (details && typeof details === "object") {
         data = Object.fromEntries(
             Object.entries(details)

components/server/src/workspace/gitpod-server-impl.ts

@@ -3464,6 +3464,10 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable {
     //
     //#endregion
 
+    /**
+     * TODO(ak)
+     * @deprecated remove it after dashboard is deployed. It was replaced with error reporting in GCP.
+     */
     async reportErrorBoundary(ctx: TraceContextWithSpan, url: string, message: string): Promise<void> {
         // Cap message and url length so the entries aren't of unbounded length
         log.warn("dashboard error boundary", {