[supervisor] Remove default image fetch to improve IDE startup performance (#18993)

* [supervisor] Remove default image fetch to improve IDE startup performance

* fix build

* address feedback

Author: mustard-mh

components/gitpod-cli/cmd/init.go

@@ -19,6 +19,8 @@ import (
 	"github.com/gitpod-io/gitpod/gitpod-cli/pkg/gitpod"
 	"github.com/gitpod-io/gitpod/gitpod-cli/pkg/gitpodlib"
 	"github.com/gitpod-io/gitpod/gitpod-cli/pkg/utils"
+	protocol "github.com/gitpod-io/gitpod/gitpod-protocol"
+	"github.com/gitpod-io/gitpod/supervisor/api"
 )
 
 var (
@@ -55,7 +57,11 @@ Create a Gitpod configuration for this project.
 			return err
 		}
 		if !interactive {
-			defaultImage, err := getDefaultWorkspaceImage(ctx)
+			wsInfo, err := gitpod.GetWSInfo(ctx)
+			if err != nil {
+				return fmt.Errorf("failed to get workspace info: %w", err)
+			}
+			defaultImage, err := getDefaultWorkspaceImage(ctx, wsInfo)
 			if err != nil {
 				fmt.Printf("failed to get organization default workspace image: %v\n", err)
 				fmt.Println("fallback to gitpod default")
@@ -125,12 +131,22 @@ USER gitpod
 	},
 }
 
-func getDefaultWorkspaceImage(ctx context.Context) (string, error) {
-	wsInfo, err := gitpod.GetWSInfo(ctx)
+func getDefaultWorkspaceImage(ctx context.Context, wsInfo *api.WorkspaceInfoResponse) (string, error) {
+	client, err := gitpod.ConnectToServer(ctx, wsInfo, []string{
+		"function:getDefaultWorkspaceImage",
+	})
+	if err != nil {
+		return "", err
+	}
+	defer client.Close()
+
+	res, err := client.GetDefaultWorkspaceImage(ctx, &protocol.GetDefaultWorkspaceImageParams{
+		WorkspaceID: wsInfo.WorkspaceId,
+	})
 	if err != nil {
 		return "", err
 	}
-	return wsInfo.DefaultWorkspaceImage, nil
+	return res.Image, nil
 }
 
 func isRequired(input string) error {
@@ -167,7 +183,11 @@ func askForDockerImage(ctx context.Context, cfg *gitpodlib.GitpodFile) error {
 	}
 
 	if chce == 0 {
-		defaultImage, err := getDefaultWorkspaceImage(ctx)
+		wsInfo, err := gitpod.GetWSInfo(ctx)
+		if err != nil {
+			return fmt.Errorf("failed to get workspace info: %w", err)
+		}
+		defaultImage, err := getDefaultWorkspaceImage(ctx, wsInfo)
 		if err != nil {
 			return fmt.Errorf("failed to get organization default workspace image: %w", err)
 		}

components/gitpod-cli/cmd/validate.go

@@ -88,7 +88,10 @@ func runRebuild(ctx context.Context, supervisorClient *supervisor.SupervisorClie
 	var dockerContext string
 	switch img := gitpodConfig.Image.(type) {
 	case nil:
-		image = wsInfo.DefaultWorkspaceImage
+		image, err = getDefaultWorkspaceImage(ctx, wsInfo)
+		if err != nil {
+			return err
+		}
 		fmt.Println("Using default workspace image:", image)
 	case string:
 		image = img

components/supervisor-api/go/info.pb.go

@@ -101,8 +101,8 @@ message WorkspaceInfoResponse {
     // configcat_enabled controls whether configcat is enabled
     bool configcat_enabled = 18;
 
-    // default_workspace_image is the default image of the workspace
-    string default_workspace_image = 19;
+    // DEPRECATED default_workspace_image is the default image of the workspace
+    reserved 19;
 }
 
 enum DebugWorkspaceType {