Skip to content

Commit aa24fb5

Browse files
WVerlaekkylos101
authored andcommitted
Fix GHA mk2 flag, add experimental label
1 parent 844a589 commit aa24fb5

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

.github/actions/deploy-gitpod/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ previewctl get-credentials --gcp-service-account "${PREVIEW_ENV_DEV_SA_KEY_PATH}
2929
PREVIEW_NAME="$(previewctl get-name --branch "${INPUT_NAME}")"
3030
export PREVIEW_NAME
3131

32-
for var in WITH_WS_MANAGER_MK2 WITH_DEDICATED_EMU WITH_EE_LICENSE ANALYTICS WORKSPACE_FEATURE_FLAGS; do
32+
for var in WSMANAGER_MK2 WITH_DEDICATED_EMU WITH_EE_LICENSE ANALYTICS WORKSPACE_FEATURE_FLAGS; do
3333
input_var="INPUT_${var}"
3434
if [[ -n "${!input_var:-}" ]];then
3535
export GITPOD_${var}=${!input_var}

.github/actions/deploy-gitpod/metadata.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ inputs:
1313
previewctl_hash:
1414
description: "The Leeway hash of the dev/preview/previewctl:docker package to be used when downloading previewclt"
1515
required: false
16-
with_ws_manager_mk2:
16+
wsmanager_mk2:
1717
description: "Use WS Manager MK2"
1818
required: false
1919
with_dedicated_emu:

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ jobs:
296296
version: ${{needs.configuration.outputs.version}}
297297
sa_key: ${{ secrets.GCP_CREDENTIALS }}
298298
previewctl_hash: ${{ needs.build-previewctl.outputs.previewctl_hash }}
299-
with_ws_manager_mk2: ${{needs.configuration.outputs.with_ws_manager_mk2}}
299+
wsmanager_mk2: ${{needs.configuration.outputs.with_ws_manager_mk2}}
300300
with_dedicated_emulation: ${{needs.configuration.outputs.with_dedicated_emulation}}
301301
with_ee_license: ${{needs.configuration.outputs.with_ee_license}}
302302
analytics: ${{needs.configuration.outputs.analytics}}

.github/workflows/workspace-integration-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ jobs:
130130
sa_key: ${{ secrets.GCP_CREDENTIALS }}
131131
version: ${{ needs.configuration.outputs.version}}
132132
previewctl_hash: ${{needs.configuration.outputs.previewctl_hash }}
133+
wsmanager_mk2: ${{ github.event.inputs.wsman_mk2 }}
133134

134135
check:
135136
name: Check for regressions
@@ -204,7 +205,7 @@ jobs:
204205
WS_MANAGER_TESTS="$BASE_TESTS_DIR/components/ws-manager"
205206
WORKSPACE_TESTS="$BASE_TESTS_DIR/workspace"
206207
207-
WS_MANAGER_MK2="${{ github.event.inputs.wsman_mk2 }}"
208+
export WS_MANAGER_MK2="${{ github.event.inputs.wsman_mk2 }}"
208209
209210
go install github.com/jstemmer/go-junit-report/v2@latest
210211

dev/preview/workflow/preview/deploy-gitpod.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -634,4 +634,8 @@ leeway run components:add-smith-token \
634634
-DPREVIEW_K3S_KUBE_CONTEXT="${PREVIEW_K3S_KUBE_CONTEXT}" \
635635
-DPREVIEW_NAMESPACE="${PREVIEW_NAMESPACE}"
636636

637+
# Add experimental node label if ws-manager-mk2 is enabled.
638+
# Remove once mk2 workspaces no longer run on experimental nodes.
639+
kubectl --kubeconfig "${PREVIEW_K3S_KUBE_PATH}" --context "${PREVIEW_K3S_KUBE_CONTEXT}" --namespace="${PREVIEW_NAMESPACE}" label nodes "${PREVIEW_K3S_KUBE_CONTEXT}" gitpod.io/experimental="true" --overwrite
640+
637641
log_success "Installation is happy: https://${DOMAIN}/workspaces"

0 commit comments

Comments
 (0)