[ws-daemon] Fix quota size regex's false positives

Author: CuriousCorrelation

components/ws-daemon/pkg/quota/size.go

@@ -31,7 +31,7 @@ const (
 )
 
 var (
-	sizeRegexp = regexp.MustCompile(`(\d+)(k|m|g|t)?`)
+	sizeRegexp = regexp.MustCompile(`^(\d+)(k|m|g|t)?$`)
 
 	// ErrInvalidSize is returned by ParseSize if input was not a valid size
 	ErrInvalidSize = errors.New("invalid size")

components/ws-daemon/pkg/quota/size_test.go

@@ -23,8 +23,8 @@ func TestParseSize(t *testing.T) {
 		{"42m", 42 * quota.Megabyte, nil},
 		{"42g", 42 * quota.Gigabyte, nil},
 		{"42t", 42 * quota.Terabyte, nil},
-		// This test should fail but doesn't because match somehow matches the regexp
-		// {"-42m", 0, quota.ErrInvalidSize},
+		{"-42m", 0, quota.ErrInvalidSize},
+		{"ab-42mcd", 0, quota.ErrInvalidSize},
 		{"abc", 0, quota.ErrInvalidSize},
 		{"99999999999999999999999999999999999999999999999999999999999999999999999999999999", 0, quota.ErrInvalidSize},
 	}