Skip to content

Commit bd36bac

Browse files
committed
Remove unnecessary changes
1 parent 1942721 commit bd36bac

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

components/ws-daemon/pkg/controller/suite_test.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,27 +77,17 @@ var _ = BeforeSuite(func() {
7777
Expect(err).ToNot(HaveOccurred())
7878
ctx, cancel = context.WithCancel(context.Background())
7979

80-
By("Setting up workspace controller")
8180
workspaceCtrl, err = NewWorkspaceController(k8sClient, record.NewFakeRecorder(100), NodeName, secretsNamespace, 5, nil, ctrl_metrics.Registry, nil)
8281
Expect(err).NotTo(HaveOccurred())
83-
Expect(workspaceCtrl.SetupWithManager(k8sManager)).To(Succeed())
8482

83+
Expect(workspaceCtrl.SetupWithManager(k8sManager)).To(Succeed())
8584
_ = createNamespace(secretsNamespace)
8685

87-
By("Starting the manager")
8886
go func() {
8987
defer GinkgoRecover()
9088
err = k8sManager.Start(ctx)
9189
Expect(err).ToNot(HaveOccurred(), "failed to run manager")
9290
}()
93-
94-
By("Waiting for controllers to be ready")
95-
DeferCleanup(cancel)
96-
97-
// Wait for controllers to be ready
98-
Eventually(func() bool {
99-
return k8sManager.GetCache().WaitForCacheSync(ctx)
100-
}, time.Second*10, time.Millisecond*100).Should(BeTrue())
10191
})
10292

10393
func createNamespace(name string) *corev1.Namespace {

components/ws-daemon/pkg/controller/workspace_controller_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ func newWorkspace(name, namespace string, phase workspacev1.WorkspacePhase) *wor
144144
Expect(err).ToNot(HaveOccurred())
145145

146146
return &workspacev1.Workspace{
147-
Status: workspacev1.WorkspaceStatus{
148-
Phase: phase,
149-
Conditions: []metav1.Condition{},
150-
},
151147
TypeMeta: metav1.TypeMeta{
152148
APIVersion: "workspace.gitpod.io/v1",
153149
Kind: "Workspace",

0 commit comments

Comments
 (0)