Skip to content

Commit cb04a49

Browse files
sagor999roboquat
authored andcommitted
[ws-daemon] log when ready probe fails
1 parent 6b11a82 commit cb04a49

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

components/ws-daemon/pkg/daemon/daemon.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
"k8s.io/client-go/rest"
1717
"k8s.io/client-go/tools/clientcmd"
1818

19+
"github.com/gitpod-io/gitpod/common-go/log"
1920
"github.com/gitpod-io/gitpod/ws-daemon/api"
2021
"github.com/gitpod-io/gitpod/ws-daemon/pkg/cgroup"
2122
"github.com/gitpod-io/gitpod/ws-daemon/pkg/container"
@@ -202,16 +203,21 @@ func (d *Daemon) Stop() error {
202203
func (d *Daemon) ReadinessProbe() func() error {
203204
return func() error {
204205
if d.hosts != nil && !d.hosts.DidUpdate() {
205-
return fmt.Errorf("host controller not ready yet")
206+
err := fmt.Errorf("host controller not ready yet")
207+
log.WithError(err).Errorf("readiness probe failure")
208+
return err
206209
}
207210

208211
isContainerdReady, err := d.dispatch.Runtime.IsContainerdReady(context.Background())
209212
if err != nil {
213+
log.WithError(err).Errorf("readiness probe failure: containerd error")
210214
return fmt.Errorf("containerd error: %v", err)
211215
}
212216

213217
if !isContainerdReady {
214-
return fmt.Errorf("containerd is not ready")
218+
err := fmt.Errorf("containerd is not ready")
219+
log.WithError(err).Error("readiness probe failure")
220+
return err
215221
}
216222

217223
return nil

0 commit comments

Comments
 (0)