[installer] change service account name

Author: mustard-mh

install/installer/pkg/components/dashboard/constants.go

@@ -10,4 +10,10 @@ const (
 	PortName      = "http"
 	ServicePort   = 3001
 	ReadinessPort = 8080
+
+	// We need a new service account because
+	// - Update old one will make preview env / dedicated deploy failed with err
+	//   The RoleBinding "dashboard" is invalid: roleRef: Invalid value: rbac.RoleRef{APIGroup:"rbac.authorization.k8s.io", Kind:"Role", Name:"dashboard"}: cannot change roleRef
+	// - Add new one will not work for dedicated since it will not clean old resources
+	ComponentServiceAccount = "dashboard-service-account"
 )

install/installer/pkg/components/dashboard/deployment.go

@@ -43,7 +43,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
 					Spec: corev1.PodSpec{
 						Affinity:                      cluster.WithNodeAffinityHostnameAntiAffinity(Component, cluster.AffinityLabelMeta),
 						TopologySpreadConstraints:     cluster.WithHostnameTopologySpread(Component),
-						ServiceAccountName:            Component,
+						ServiceAccountName:            ComponentServiceAccount,
 						EnableServiceLinks:            pointer.Bool(false),
 						DNSPolicy:                     corev1.DNSClusterFirst,
 						RestartPolicy:                 corev1.RestartPolicyAlways,

install/installer/pkg/components/dashboard/role.go

@@ -16,7 +16,7 @@ func Role(ctx *common.RenderContext) ([]runtime.Object, error) {
 	return []runtime.Object{&rbacv1.Role{
 		TypeMeta: common.TypeMetaRole,
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      Component,
+			Name:      ComponentServiceAccount,
 			Namespace: ctx.Namespace,
 			Labels:    common.DefaultLabels(Component),
 		},

install/installer/pkg/components/dashboard/rolebinding.go

@@ -16,18 +16,18 @@ func rolebinding(ctx *common.RenderContext) ([]runtime.Object, error) {
 	return []runtime.Object{&rbacv1.RoleBinding{
 		TypeMeta: common.TypeMetaRoleBinding,
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      Component,
+			Name:      ComponentServiceAccount,
 			Namespace: ctx.Namespace,
 			Labels:    common.DefaultLabels(Component),
 		},
 		RoleRef: rbacv1.RoleRef{
 			Kind:     "Role",
-			Name:     Component,
+			Name:     ComponentServiceAccount,
 			APIGroup: "rbac.authorization.k8s.io",
 		},
 		Subjects: []rbacv1.Subject{{
 			Kind: "ServiceAccount",
-			Name: Component,
+			Name: ComponentServiceAccount,
 		}},
 	}}, nil
 }