Skip to content

Commit db97cc1

Browse files
committed
cleanup
1 parent 8fcdbd6 commit db97cc1

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

test/pkg/integration/workspace.go

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -374,19 +374,7 @@ func LaunchWorkspaceWithOptions(t *testing.T, ctx context.Context, opts *LaunchW
374374
var resp *protocol.WorkspaceCreationResult
375375
for i := 0; i < 3; i++ {
376376
t.Logf("attempt to create the workspace: %s, with defaultIde: %s", opts.ContextURL, opts.IDESettings.DefaultIde)
377-
// TODO: add a user check to avoid obscure failures
378-
// If we try using a user who is not in Github, or the one who created the env, the tests silently fail
379-
// impacts TestGitHooks, TestGitActions, and TestGitHubContexts
380-
381-
// user, uerr := server.GetLoggedInUser(cctx)
382-
// if uerr != nil {
383-
// return nil, nil, xerrors.Errorf("cannot get logged in user: %w", uerr)
384-
// }
385-
// hasAdmin := slices.Contains(user.RolesOrPermissions, "admin")
386-
// if !hasAdmin {
387-
// return nil, nil, xerrors.Errorf("user lacks get logged in user: %w", uerr)
388-
// }
389-
// t.Logf("with user identity: %s", user.ID)
377+
390378
resp, err = server.CreateWorkspace(cctx, &protocol.CreateWorkspaceOptions{
391379
ContextURL: opts.ContextURL,
392380
IgnoreRunningPrebuild: true,

0 commit comments

Comments
 (0)