Implement searchRepos for Bitbucket (#18856)

* implementing searchRepositories

* implement searchRepos for BBS

* limit fields

* remove fields

* adding gitlab searchRepos

* remove gitlab searchRepos - not working will do in a followup

* wrap calls w/ asyncBatch to limit concurrency

Author: selfcontained

components/server/package.json

@@ -62,6 +62,7 @@
     "@octokit/rest": "18.6.1",
     "@probot/get-private-key": "^1.1.1",
     "@types/jaeger-client": "^3.18.3",
+    "async-batch": "^1.1.2",
     "base-64": "^1.0.0",
     "bitbucket": "^2.7.0",
     "body-parser": "^1.19.2",

components/server/src/bitbucket-server/bitbucket-server-repository-provider.ts

@@ -188,8 +188,21 @@ export class BitbucketServerRepositoryProvider implements RepositoryProvider {
         return commits.map((c) => c.id);
     }
 
-    // TODO: implement repo search
     public async searchRepos(user: User, searchString: string): Promise<RepositoryInfo[]> {
-        return [];
+        // Only load 1 page of 10 results for our searchString
+        const results = await this.api.getRepos(user, { maxPages: 1, limit: 10, searchString });
+
+        const repos: RepositoryInfo[] = [];
+        results.forEach((r) => {
+            const cloneUrl = r.links.clone.find((u) => u.name === "http")?.href;
+            if (cloneUrl) {
+                repos.push({
+                    url: cloneUrl.replace("http://", "https://"),
+                    name: r.name,
+                });
+            }
+        });
+
+        return repos;
     }
 }

components/server/src/bitbucket/bitbucket-repository-provider.ts

@@ -11,6 +11,7 @@ import { URL } from "url";
 import { RepoURL } from "../repohost/repo-url";
 import { RepositoryProvider } from "../repohost/repository-provider";
 import { BitbucketApiFactory } from "./bitbucket-api-factory";
+import asyncBatch from "async-batch";
 
 @injectable()
 export class BitbucketRepositoryProvider implements RepositoryProvider {
@@ -157,8 +158,63 @@ export class BitbucketRepositoryProvider implements RepositoryProvider {
         return commits.map((v: Schema.Commit) => v.hash!);
     }
 
-    // TODO: implement repo search
+    //
+    // Searching Bitbucket requires a workspace to be specified
+    // This results in a two step process:
+    // 1. Get all workspaces for the user
+    // 2. Fan out and search each workspace for the repos
+    //
     public async searchRepos(user: User, searchString: string): Promise<RepositoryInfo[]> {
-        return [];
+        const api = await this.apiFactory.create(user);
+
+        const workspaces = await api.workspaces.getWorkspaces({ pagelen: 25 });
+
+        const workspaceSlugs: string[] = (
+            workspaces.data.values?.map((w) => {
+                return w.slug || "";
+            }) ?? []
+        ).filter(Boolean);
+
+        if (workspaceSlugs.length === 0) {
+            return [];
+        }
+
+        // Batch our requests to the api so we only make up to 5 calls in parallel
+        const results = await asyncBatch(
+            workspaceSlugs,
+            async (workspaceSlug) => {
+                return api.repositories.list({
+                    workspace: workspaceSlug,
+                    // name includes searchString
+                    q: `name ~ "${searchString}"`,
+                    // sort by most recently updatd first
+                    sort: "-updated_on",
+                    // limit to the first 10 results per workspace
+                    pagelen: 10,
+                });
+            },
+            // 5 calls in parallel
+            5,
+        );
+
+        // Convert into RepositoryInfo
+        const repos: RepositoryInfo[] = [];
+
+        results
+            .map((result) => {
+                return result.data.values ?? [];
+            })
+            // flatten out the array of arrays
+            .flat()
+            // convert into the format we want to return
+            .forEach((repo) => {
+                const name = repo.name;
+                const url = repo.links?.html?.href;
+                if (name && url) {
+                    repos.push({ name, url });
+                }
+            });
+
+        return repos;
     }
 }

yarn.lock

@@ -4424,6 +4424,11 @@ ast-types-flow@^0.0.7:
   resolved "https://registry.npmjs.org/ast-types-flow/-/ast-types-flow-0.0.7.tgz"
   integrity sha1-9wtzXGvKGlycItmCw+Oef+ujva0=
 
+async-batch@^1.1.2:
+  version "1.1.2"
+  resolved "https://registry.yarnpkg.com/async-batch/-/async-batch-1.1.2.tgz#ecac7dee0f02a1a3a846438ba7d3f96746239d79"
+  integrity sha512-tBR4YIKi7s1cCtNHuguyXVBdRSkS6N8OhM1czrpE0W2j2yovj/IAxXD187cNX0d+kGxBbZLPwW5ASonYuZJprA==
+
 async@^3.2.3:
   version "3.2.4"
   resolved "https://registry.yarnpkg.com/async/-/async-3.2.4.tgz#2d22e00f8cddeb5fde5dd33522b56d1cf569a81c"