address feedback

Author: mustard-mh

components/dashboard/src/workspaces/WorkspaceEntry.tsx

@@ -13,7 +13,6 @@ import dayjs from "dayjs";
 import { WorkspaceEntryOverflowMenu } from "./WorkspaceOverflowMenu";
 import { WorkspaceStatusIndicator } from "./WorkspaceStatusIndicator";
 import { Workspace } from "@gitpod/public-api/lib/gitpod/v1/workspace_pb";
-import { ContextURL } from "@gitpod/gitpod-protocol";
 
 type Props = {
     info: Workspace;
@@ -105,11 +104,6 @@ export const WorkspaceEntry: FunctionComponent<Props> = ({ info, shortVersion })
 };
 
 export function getProjectPath(ws: Workspace) {
-    // we don't need to provide context here, only contextURL is needed
     // TODO: Remove and call papi ContextService
-    const url = ContextURL.getNormalizedURL({ context: { title: ws.name }, contextURL: ws.contextUrl });
-    if (!url) {
-        return ws.contextUrl.replace("https://", "");
-    }
-    return [url.host, url.pathname].join("");
+    return ws.contextUrl.replace("https://", "");
 }

components/public-api/gitpod/v1/workspace.proto

@@ -24,7 +24,12 @@ service WorkspaceService {
   rpc ListWorkspaces(ListWorkspacesRequest) returns (ListWorkspacesResponse) {}
 }
 
-message GetWorkspaceRequest { string workspace_id = 1; }
+message GetWorkspaceRequest {
+  // workspace_id specifies the workspace to get
+  //
+  // +required
+  string workspace_id = 1;
+}
 
 message GetWorkspaceResponse { Workspace workspace = 1; }
 
@@ -48,6 +53,8 @@ message ListWorkspacesRequest {
   PaginationRequest pagination = 1;
 
   // organization_id is the ID of the organization that contains the workspaces
+  //
+  // +required
   string organization_id = 2;
 
   // pinned indicates whether to list only pinned workspaces