Skip to content

Commit e122c8d

Browse files
committed
address review comments
1 parent 1641a05 commit e122c8d

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

components/dashboard/src/service/json-rpc-scm-client.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,9 @@ export class JsonRpcScmClient implements PromiseClient<typeof SCMService> {
2727
throw new ApplicationError(ErrorCodes.BAD_REQUEST, "host is required");
2828
}
2929
const response = new SearchSCMTokensResponse();
30-
try {
31-
const token = await getGitpodService().server.getToken({ host });
32-
if (token) {
33-
response.tokens.push(converter.toSCMToken(token));
34-
}
35-
} catch (error) {
36-
throw new ApplicationError(ErrorCodes.NOT_FOUND, "token not found");
30+
const token = await getGitpodService().server.getToken({ host });
31+
if (token) {
32+
response.tokens.push(converter.toSCMToken(token));
3733
}
3834
return response;
3935
}
@@ -53,7 +49,7 @@ export class JsonRpcScmClient implements PromiseClient<typeof SCMService> {
5349
});
5450
return new GuessTokenScopesResponse({
5551
message: response.message,
56-
scopes: response.scopes,
52+
scopes: response.scopes || [],
5753
});
5854
}
5955

0 commit comments

Comments
 (0)