Skip to content

Commit e292a59

Browse files
authored
[registry-facade] do not log node-labeler inquires as errors (#17099)
1 parent 3fc2826 commit e292a59

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

components/registry-facade/pkg/registry/manifest.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,18 @@ func (reg *Registry) handleManifest(ctx context.Context, r *http.Request) http.H
4545
}
4646
spec, err := sp.GetSpec(ctx, name)
4747
if err != nil {
48-
log.WithError(err).WithField("specProvName", spname).WithField("name", name).Error("cannot get spec")
48+
// treat invalid names from node-labeler as debug, not errors
49+
// ref: https://github.com/gitpod-io/gitpod/blob/1a3c4b0bb6f13fe38481d21ddd146747c1a1935f/components/node-labeler/cmd/run.go#L291
50+
var isNodeLabeler bool
51+
if name == "not-a-valid-image" {
52+
isNodeLabeler = true
53+
}
54+
if isNodeLabeler {
55+
log.WithError(err).WithField("specProvName", spname).WithField("name", name).Info("this was node-labeler, we expected no spec")
56+
} else {
57+
log.WithError(err).WithField("specProvName", spname).WithField("name", name).Error("cannot get spec")
58+
}
59+
4960
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
5061
respondWithError(w, distv2.ErrorCodeManifestUnknown)
5162
})

0 commit comments

Comments
 (0)