Skip to content

Commit e45870a

Browse files
committed
[ws-manager-api] Remove deprecated fields
1 parent e947903 commit e45870a

File tree

5 files changed

+231
-411
lines changed

5 files changed

+231
-411
lines changed

components/server/src/workspace/workspace-starter.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1533,7 +1533,6 @@ export class WorkspaceStarter {
15331533
startWorkspaceSpecIDEImage.setSupervisorRef(ideConfig.supervisorImage);
15341534
spec.setIdeImage(startWorkspaceSpecIDEImage);
15351535
spec.setIdeImageLayersList(ideConfig.ideImageLayers);
1536-
spec.setDeprecatedIdeImage(ideConfig.webImage);
15371536
spec.setWorkspaceImage(instance.workspaceImage);
15381537
spec.setWorkspaceLocation(workspace.config.workspaceLocation || checkoutLocation);
15391538
spec.setFeatureFlagsList(this.toWorkspaceFeatureFlags(featureFlags));

components/ws-manager-api/core.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,11 +328,11 @@ message IDEImage {
328328
// web_ref is a reference to an OCI image used for serving the web-based IDE
329329
string web_ref = 1;
330330
// DEPRECATED desktop_ref is an optional reference to an OCI image used for serving desktop IDEs
331-
string desktop_ref = 2;
331+
reserved 2;
332332
// supervisor_ref is a reference to an OCI image used as supervisor
333333
string supervisor_ref = 3;
334334
// DEPRECATED desktop_plugin_ref is an optional reference to an OCI image used for serving desktop IDE plugin
335-
string desktop_plugin_ref = 4;
335+
reserved 4;
336336
}
337337

338338
// WorkspaceSpec is the specification of a workspace at runtime
@@ -342,7 +342,7 @@ message WorkspaceSpec {
342342

343343
// deprecated_ide_image is a field present for backwards compatibility and the same
344344
// as IDEImage.web_ref. If both fields are present, IDEImage.web_ref takes precedence.
345-
string deprecated_ide_image = 2;
345+
reserved 2;
346346

347347
// headless marks this workspace a headless one - headless workspaces are not intended for users but for automation
348348
bool headless = 3;
@@ -559,7 +559,7 @@ message StartWorkspaceSpec {
559559

560560
// deprecated_ide_image is a field present for backwards compatibility and the same
561561
// as IDEImage.web_ref. If both fields are present, IDEImage.web_ref takes precedence.
562-
string deprecated_ide_image = 2;
562+
reserved 2;
563563

564564
// feature_flags provide a means for starting variants of workspaces (e.g. a privileged one)
565565
repeated WorkspaceFeatureFlag feature_flags = 3;

0 commit comments

Comments
 (0)