Skip to content

Commit e770692

Browse files
committed
fixup fromWorkspaceAutostartOption
1 parent 47dd751 commit e770692

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

components/public-api/typescript-common/src/public-api-converter.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* See License.AGPL.txt in the project root for license information.
55
*/
66

7+
import "reflect-metadata";
8+
79
import { Timestamp, toPlainMessage, PartialMessage, Duration } from "@bufbuild/protobuf";
810
import { Code, ConnectError } from "@connectrpc/connect";
911
import {
@@ -137,6 +139,7 @@ import { BlockedRepository as ProtocolBlockedRepository } from "@gitpod/gitpod-p
137139
import { SupportedWorkspaceClass } from "@gitpod/gitpod-protocol/lib/workspace-class";
138140
import { RoleOrPermission } from "@gitpod/gitpod-protocol/lib/permission";
139141
import { parseGoDurationToMs } from "@gitpod/gitpod-protocol/lib/util/timeutil";
142+
import { isWorkspaceRegion } from "@gitpod/gitpod-protocol/lib/workspace-cluster";
140143

141144
export type PartialConfiguration = DeepPartial<Configuration> & Pick<Configuration, "id">;
142145

@@ -1239,7 +1242,7 @@ export class PublicAPIConverter {
12391242
if (!e) {
12401243
return undefined;
12411244
}
1242-
return <IDESettings>{
1245+
return {
12431246
defaultIde: e.name,
12441247
useLatestVersion: e.version === "latest",
12451248
};
@@ -1256,11 +1259,12 @@ export class PublicAPIConverter {
12561259
}
12571260

12581261
fromWorkspaceAutostartOption(o: User_WorkspaceAutostartOption): WorkspaceAutostartOption {
1259-
return <WorkspaceAutostartOption>{
1262+
const region = isWorkspaceRegion(o.region) ? o.region : "";
1263+
return {
12601264
cloneURL: o.cloneUrl,
1261-
editorSettings: this.fromEditorReference(o.editorSettings),
1265+
ideSettings: this.fromEditorReference(o.editorSettings),
12621266
organizationId: o.organizationId,
1263-
region: o.region,
1267+
region,
12641268
workspaceClass: o.workspaceClass,
12651269
};
12661270
}

components/server/src/user/user-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { CreateUserParams } from "./user-authentication";
2424
import { IAnalyticsWriter } from "@gitpod/gitpod-protocol/lib/analytics";
2525
import { TransactionalContext } from "@gitpod/gitpod-db/lib/typeorm/transactional-db-impl";
2626
import { RelationshipUpdater } from "../authorization/relationship-updater";
27-
import { getProfile } from "@gitpod/public-api-common/src/user-utils";
27+
import { getProfile } from "@gitpod/public-api-common/lib/user-utils";
2828

2929
@injectable()
3030
export class UserService {

0 commit comments

Comments
 (0)