Skip to content

Commit ef090bb

Browse files
csweichelroboquat
csweichel
authored and
roboquat
committed
[ws-manager] Pull images if not present
1 parent ed076d7 commit ef090bb

File tree

45 files changed

+45
-45
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+45
-45
lines changed

‎components/ws-manager/pkg/manager/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ func (m *Manager) createWorkspaceContainer(startContext *startWorkspaceContext)
468468
Name: "workspace",
469469
Image: image,
470470
SecurityContext: sec,
471-
ImagePullPolicy: corev1.PullAlways,
471+
ImagePullPolicy: corev1.PullIfNotPresent,
472472
Ports: []corev1.ContainerPort{
473473
{ContainerPort: startContext.IDEPort},
474474
},

‎components/ws-manager/pkg/manager/testdata/cdwp_admission.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"failureThreshold": 600
170170
},
171171
"terminationMessagePolicy": "File",
172-
"imagePullPolicy": "Always",
172+
"imagePullPolicy": "IfNotPresent",
173173
"securityContext": {
174174
"capabilities": {
175175
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_empty_resource_req.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
"failureThreshold": 600
164164
},
165165
"terminationMessagePolicy": "File",
166-
"imagePullPolicy": "Always",
166+
"imagePullPolicy": "IfNotPresent",
167167
"securityContext": {
168168
"capabilities": {
169169
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_fixedresources.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
"failureThreshold": 600
167167
},
168168
"terminationMessagePolicy": "File",
169-
"imagePullPolicy": "Always",
169+
"imagePullPolicy": "IfNotPresent",
170170
"securityContext": {
171171
"capabilities": {
172172
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_fullworkspacebackup.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
"failureThreshold": 600
156156
},
157157
"terminationMessagePolicy": "File",
158-
"imagePullPolicy": "Always",
158+
"imagePullPolicy": "IfNotPresent",
159159
"securityContext": {
160160
"capabilities": {
161161
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_ghost.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
}
159159
],
160160
"terminationMessagePolicy": "File",
161-
"imagePullPolicy": "Always",
161+
"imagePullPolicy": "IfNotPresent",
162162
"securityContext": {
163163
"capabilities": {
164164
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_prebuild.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"failureThreshold": 600
170170
},
171171
"terminationMessagePolicy": "File",
172-
"imagePullPolicy": "Always",
172+
"imagePullPolicy": "IfNotPresent",
173173
"securityContext": {
174174
"capabilities": {
175175
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
"failureThreshold": 600
174174
},
175175
"terminationMessagePolicy": "File",
176-
"imagePullPolicy": "Always",
176+
"imagePullPolicy": "IfNotPresent",
177177
"securityContext": {
178178
"capabilities": {
179179
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template_override_resources.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
"failureThreshold": 600
174174
},
175175
"terminationMessagePolicy": "File",
176-
"imagePullPolicy": "Always",
176+
"imagePullPolicy": "IfNotPresent",
177177
"securityContext": {
178178
"capabilities": {
179179
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_probe.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"failureThreshold": 600
170170
},
171171
"terminationMessagePolicy": "File",
172-
"imagePullPolicy": "Always",
172+
"imagePullPolicy": "IfNotPresent",
173173
"securityContext": {
174174
"capabilities": {
175175
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_readinessprobe.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
"failureThreshold": 600
166166
},
167167
"terminationMessagePolicy": "File",
168-
"imagePullPolicy": "Always",
168+
"imagePullPolicy": "IfNotPresent",
169169
"securityContext": {
170170
"capabilities": {
171171
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_tasks.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"failureThreshold": 600
170170
},
171171
"terminationMessagePolicy": "File",
172-
"imagePullPolicy": "Always",
172+
"imagePullPolicy": "IfNotPresent",
173173
"securityContext": {
174174
"capabilities": {
175175
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_template.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"failureThreshold": 600
170170
},
171171
"terminationMessagePolicy": "File",
172-
"imagePullPolicy": "Always",
172+
"imagePullPolicy": "IfNotPresent",
173173
"securityContext": {
174174
"capabilities": {
175175
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_timeout.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
"failureThreshold": 600
171171
},
172172
"terminationMessagePolicy": "File",
173-
"imagePullPolicy": "Always",
173+
"imagePullPolicy": "IfNotPresent",
174174
"securityContext": {
175175
"capabilities": {
176176
"add": [

‎components/ws-manager/pkg/manager/testdata/cdwp_userns.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
"failureThreshold": 600
166166
},
167167
"terminationMessagePolicy": "File",
168-
"imagePullPolicy": "Always",
168+
"imagePullPolicy": "IfNotPresent",
169169
"securityContext": {
170170
"capabilities": {
171171
"add": [

‎components/ws-manager/pkg/manager/testdata/getWorkspaces_podOnly.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
}
132132
],
133133
"image": "eu.gcr.io/gitpod-dev/workspace-images:a4d95e78185ee17b09e21a79939393f4eec08d6c247c1b52696172db0a6349f7",
134-
"imagePullPolicy": "Always",
134+
"imagePullPolicy": "IfNotPresent",
135135
"name": "workspace",
136136
"ports": [
137137
{

‎components/ws-manager/pkg/manager/testdata/status_brokenScheduler_UNKNOWN00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
},
175175
"terminationMessagePath": "/dev/termination-log",
176176
"terminationMessagePolicy": "File",
177-
"imagePullPolicy": "Always",
177+
"imagePullPolicy": "IfNotPresent",
178178
"securityContext": {
179179
"capabilities": {
180180
"add": [

‎components/ws-manager/pkg/manager/testdata/status_containerd4214_STOPPING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@
218218
},
219219
"terminationMessagePath": "/dev/termination-log",
220220
"terminationMessagePolicy": "File",
221-
"imagePullPolicy": "Always",
221+
"imagePullPolicy": "IfNotPresent",
222222
"securityContext": {
223223
"capabilities": {
224224
"add": [

‎components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
},
189189
"terminationMessagePath": "/dev/termination-log",
190190
"terminationMessagePolicy": "File",
191-
"imagePullPolicy": "Always",
191+
"imagePullPolicy": "IfNotPresent",
192192
"securityContext": {
193193
"capabilities": {
194194
"add": [

‎components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED02.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
},
189189
"terminationMessagePath": "/dev/termination-log",
190190
"terminationMessagePolicy": "File",
191-
"imagePullPolicy": "Always",
191+
"imagePullPolicy": "IfNotPresent",
192192
"securityContext": {
193193
"capabilities": {
194194
"add": [

‎components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED03.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
},
189189
"terminationMessagePath": "/dev/termination-log",
190190
"terminationMessagePolicy": "File",
191-
"imagePullPolicy": "Always",
191+
"imagePullPolicy": "IfNotPresent",
192192
"securityContext": {
193193
"capabilities": {
194194
"add": [

‎components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@
191191
},
192192
"terminationMessagePath": "/dev/termination-log",
193193
"terminationMessagePolicy": "File",
194-
"imagePullPolicy": "Always",
194+
"imagePullPolicy": "IfNotPresent",
195195
"securityContext": {
196196
"capabilities": {
197197
"add": [

‎components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING02.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@
191191
},
192192
"terminationMessagePath": "/dev/termination-log",
193193
"terminationMessagePolicy": "File",
194-
"imagePullPolicy": "Always",
194+
"imagePullPolicy": "IfNotPresent",
195195
"securityContext": {
196196
"capabilities": {
197197
"add": [

‎components/ws-manager/pkg/manager/testdata/status_errimgpull.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
},
162162
"terminationMessagePath": "/dev/termination-log",
163163
"terminationMessagePolicy": "File",
164-
"imagePullPolicy": "Always",
164+
"imagePullPolicy": "IfNotPresent",
165165
"securityContext": {
166166
"capabilities": {
167167
"add": [

‎components/ws-manager/pkg/manager/testdata/status_errimgpull_CREATING01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
},
160160
"terminationMessagePath": "/dev/termination-log",
161161
"terminationMessagePolicy": "File",
162-
"imagePullPolicy": "Always",
162+
"imagePullPolicy": "IfNotPresent",
163163
"securityContext": {
164164
"capabilities": {
165165
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedBeforeStopping_explicitFail.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
},
174174
"terminationMessagePath": "/dev/termination-log",
175175
"terminationMessagePolicy": "File",
176-
"imagePullPolicy": "Always",
176+
"imagePullPolicy": "IfNotPresent",
177177
"securityContext": {
178178
"capabilities": {
179179
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedLogs_UNKNOWN00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
},
171171
"terminationMessagePath": "/dev/termination-log",
172172
"terminationMessagePolicy": "File",
173-
"imagePullPolicy": "Always",
173+
"imagePullPolicy": "IfNotPresent",
174174
"securityContext": {
175175
"capabilities": {
176176
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
},
9797
"terminationMessagePath": "/dev/termination-log",
9898
"terminationMessagePolicy": "File",
99-
"imagePullPolicy": "Always",
99+
"imagePullPolicy": "IfNotPresent",
100100
"securityContext": {
101101
"capabilities": {
102102
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN02.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
},
102102
"terminationMessagePath": "/dev/termination-log",
103103
"terminationMessagePolicy": "File",
104-
"imagePullPolicy": "Always",
104+
"imagePullPolicy": "IfNotPresent",
105105
"securityContext": {
106106
"capabilities": {
107107
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedTheiaMount_PENDING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
},
171171
"terminationMessagePath": "/dev/termination-log",
172172
"terminationMessagePolicy": "File",
173-
"imagePullPolicy": "Always",
173+
"imagePullPolicy": "IfNotPresent",
174174
"securityContext": {
175175
"capabilities": {
176176
"add": [

‎components/ws-manager/pkg/manager/testdata/status_failedWorkspaceMount_PENDING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
},
171171
"terminationMessagePath": "/dev/termination-log",
172172
"terminationMessagePolicy": "File",
173-
"imagePullPolicy": "Always",
173+
"imagePullPolicy": "IfNotPresent",
174174
"securityContext": {
175175
"capabilities": {
176176
"add": [

‎components/ws-manager/pkg/manager/testdata/status_firstUserActivity_RUNNING.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
},
9999
"terminationMessagePath": "/dev/termination-log",
100100
"terminationMessagePolicy": "File",
101-
"imagePullPolicy": "Always",
101+
"imagePullPolicy": "IfNotPresent",
102102
"securityContext": {
103103
"capabilities": {
104104
"add": [

‎components/ws-manager/pkg/manager/testdata/status_imagespec_RUNNING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
},
157157
"terminationMessagePath": "/dev/termination-log",
158158
"terminationMessagePolicy": "File",
159-
"imagePullPolicy": "Always",
159+
"imagePullPolicy": "IfNotPresent",
160160
"securityContext": {
161161
"capabilities": {
162162
"add": [

‎components/ws-manager/pkg/manager/testdata/status_interrupted.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
},
160160
"terminationMessagePath": "/dev/termination-log",
161161
"terminationMessagePolicy": "File",
162-
"imagePullPolicy": "Always",
162+
"imagePullPolicy": "IfNotPresent",
163163
"securityContext": {
164164
"capabilities": {
165165
"add": [

‎components/ws-manager/pkg/manager/testdata/status_interrupted_CREATING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
},
157157
"terminationMessagePath": "/dev/termination-log",
158158
"terminationMessagePolicy": "File",
159-
"imagePullPolicy": "Always",
159+
"imagePullPolicy": "IfNotPresent",
160160
"securityContext": {
161161
"capabilities": {
162162
"add": [

‎components/ws-manager/pkg/manager/testdata/status_interrupted_networkNotReady_1_event_only.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
},
9797
"terminationMessagePath": "/dev/termination-log",
9898
"terminationMessagePolicy": "File",
99-
"imagePullPolicy": "Always",
99+
"imagePullPolicy": "IfNotPresent",
100100
"securityContext": {
101101
"capabilities": {
102102
"add": [

‎components/ws-manager/pkg/manager/testdata/status_interrupted_networkNotReady_2_event_and_exitcode.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
},
162162
"terminationMessagePath": "/dev/termination-log",
163163
"terminationMessagePolicy": "File",
164-
"imagePullPolicy": "Always",
164+
"imagePullPolicy": "IfNotPresent",
165165
"securityContext": {
166166
"capabilities": {
167167
"add": [

‎components/ws-manager/pkg/manager/testdata/status_interrupted_networkNotReady_3_recovered_CONSTRUCTED.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
},
162162
"terminationMessagePath": "/dev/termination-log",
163163
"terminationMessagePolicy": "File",
164-
"imagePullPolicy": "Always",
164+
"imagePullPolicy": "IfNotPresent",
165165
"securityContext": {
166166
"capabilities": {
167167
"add": [

‎components/ws-manager/pkg/manager/testdata/status_ownerToken.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
},
101101
"terminationMessagePath": "/dev/termination-log",
102102
"terminationMessagePolicy": "File",
103-
"imagePullPolicy": "Always",
103+
"imagePullPolicy": "IfNotPresent",
104104
"securityContext": {
105105
"capabilities": {
106106
"add": [

‎components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPED00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
},
212212
"terminationMessagePath": "/dev/termination-log",
213213
"terminationMessagePolicy": "File",
214-
"imagePullPolicy": "Always",
214+
"imagePullPolicy": "IfNotPresent",
215215
"securityContext": {
216216
"capabilities": {
217217
"add": [

‎components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@
206206
},
207207
"terminationMessagePath": "/dev/termination-log",
208208
"terminationMessagePolicy": "File",
209-
"imagePullPolicy": "Always",
209+
"imagePullPolicy": "IfNotPresent",
210210
"securityContext": {
211211
"capabilities": {
212212
"add": [

‎components/ws-manager/pkg/manager/testdata/status_stuckInCreating_CREATING00.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
},
9999
"terminationMessagePath": "/dev/termination-log",
100100
"terminationMessagePolicy": "File",
101-
"imagePullPolicy": "Always",
101+
"imagePullPolicy": "IfNotPresent",
102102
"securityContext": {
103103
"capabilities": {
104104
"add": [

‎components/ws-manager/pkg/manager/testdata/stopping_basic.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
},
100100
"terminationMessagePath": "/dev/termination-log",
101101
"terminationMessagePolicy": "File",
102-
"imagePullPolicy": "Always",
102+
"imagePullPolicy": "IfNotPresent",
103103
"securityContext": {
104104
"capabilities": {
105105
"add": [

‎components/ws-manager/pkg/manager/testdata/timeout_interrupted_noActivity.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
},
162162
"terminationMessagePath": "/dev/termination-log",
163163
"terminationMessagePolicy": "File",
164-
"imagePullPolicy": "Always",
164+
"imagePullPolicy": "IfNotPresent",
165165
"securityContext": {
166166
"capabilities": {
167167
"add": [

0 commit comments

Comments
 (0)