Skip to content

New Settings option & New Workspace ... fix #16596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2023
Merged

New Settings option & New Workspace ... fix #16596

merged 2 commits into from
Mar 3, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Feb 28, 2023 •
edited
Loading

Description

Related #16540 #16588

Screen.Recording.2023-02-28.at.9.11.11.AM.mov

Related Issue(s)

Fixes #

How to test

Release Notes

Access Project Settings directly from Projects Page on Project Menu Items

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-feat-project-settings-from-list-item.1 because the annotations in the pull request description changed
(with .werft/ from main)

@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review February 28, 2023 03:42
@Siddhant-K-code Siddhant-K-code requested a review from a team February 28, 2023 03:42
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 28, 2023
selfcontained
selfcontained reviewed Feb 28, 2023
View reviewed changes
components/dashboard/src/projects/Project.tsx
@@ -382,7 +382,7 @@ export default function ProjectsPage() {
? []
: [
{
title: "New Workspace ...",
title: "New Workspace with ...",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I think this additional option will go away shortly and we'll be navigating to a new start workspace page where options are always available. I see we already approved merging this wording change a few times, so don't want to block it.

@selfcontained
Copy link
Contributor

I'm seeing the issue w/ the blank page after clicking settings in most of the scenarios I'm trying. I'm sure this is related to the bug you shared, and nothing specific with your changes. I think we should wait on merging this though until we fix that Projects Settings page issue though so it isn't more of a problem. Once that's fixed though, this seems safe to add.

@selfcontained
Copy link
Contributor

FYI I found the issue, and have it fixed in #16627

@gtsiolis gtsiolis force-pushed the feat/project-settings-from-list-item branch from e9b4c9f to da1c422 Compare March 2, 2023 17:36
@selfcontained
Copy link
Contributor

selfcontained commented Mar 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-feat-project-settings-from-list-item.3
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Mar 3, 2023

Add hold to unblock merge queue

@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Mar 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run recreate-vm

👍 started the job as gitpod-build-feat-project-settings-from-list-item.5
(with .werft/ from main)

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 2e519e7 into main Mar 3, 2023
@roboquat roboquat deleted the feat/project-settings-from-list-item branch March 3, 2023 05:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfcontained selfcontained selfcontained approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Siddhant-K-code @selfcontained @iQQBot @roboquat