Skip to content

[installer] Remove OIDC secret from public-api WEB-206 #17331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2023
Merged

[installer] Remove OIDC secret from public-api WEB-206 #17331

merged 6 commits into from
Apr 24, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 23, 2023 •
edited by github-actions bot
Loading

Description

  • Removes OIDC symmetric key/secret, no longer needed as we are using RSA generated by cert manager

Related Issue(s)

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ requested a review from a team April 23, 2023 07:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 23, 2023
@easyCZ easyCZ force-pushed the mp/papi-oidc-jwt-rsa256 branch from 793a04c to 74f4fbe Compare April 24, 2023 07:16
Base automatically changed from mp/papi-oidc-jwt-rsa256 to main April 24, 2023 09:14
@roboquat roboquat added size/XXL and removed size/M labels Apr 24, 2023
@easyCZ easyCZ force-pushed the mp/papi-remove-oidc-secret branch from 35b135b to 4b5a658 Compare April 24, 2023 09:19
@roboquat roboquat added size/M and removed size/XXL labels Apr 24, 2023
geropl
geropl approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

/unhold

@roboquat roboquat merged commit 1cdb7ab into main Apr 24, 2023
@roboquat roboquat deleted the mp/papi-remove-oidc-secret branch April 24, 2023 12:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @geropl @roboquat