Fix compilation

Tool: gitpod/catfood.gitpod.cloud

Author: mustard-mh

src/vs/base/common/uuid.ts

@@ -10,18 +10,34 @@ export function isUUID(value: string): boolean {
 	return _UUIDPattern.test(value);
 }
 
+declare const crypto: undefined | {
+	//https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues#browser_compatibility
+	getRandomValues?(data: Uint8Array): Uint8Array;
+	//https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID#browser_compatibility
+	randomUUID?(): string;
+};
+
 export const generateUuid = (function (): () => string {
 
 	// use `randomUUID` if possible
-	if (typeof crypto.randomUUID === 'function') {
-		// see https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto
-		// > Although crypto is available on all windows, the returned Crypto object only has one
-		// > usable feature in insecure contexts: the getRandomValues() method.
-		// > In general, you should use this API only in secure contexts.
-
+	if (typeof crypto === 'object' && typeof crypto.randomUUID === 'function') {
 		return crypto.randomUUID.bind(crypto);
 	}
 
+	// use `randomValues` if possible
+	let getRandomValues: (bucket: Uint8Array) => Uint8Array;
+	if (typeof crypto === 'object' && typeof crypto.getRandomValues === 'function') {
+		getRandomValues = crypto.getRandomValues.bind(crypto);
+
+	} else {
+		getRandomValues = function (bucket: Uint8Array): Uint8Array {
+			for (let i = 0; i < bucket.length; i++) {
+				bucket[i] = Math.floor(Math.random() * 256);
+			}
+			return bucket;
+		};
+	}
+
 	// prep-work
 	const _data = new Uint8Array(16);
 	const _hex: string[] = [];
@@ -31,7 +47,7 @@ export const generateUuid = (function (): () => string {
 
 	return function generateUuid(): string {
 		// get data
-		crypto.getRandomValues(_data);
+		getRandomValues(_data);
 
 		// set version bits
 		_data[6] = (_data[6] & 0x0f) | 0x40;

src/vs/gitpod/browser/workbench/workbench.ts

@@ -4,10 +4,10 @@
  *  Copyright (c) Gitpod. All rights reserved.
  *--------------------------------------------------------------------------------------------*/
 
-/// <reference types='@gitpod/gitpod-protocol/lib/typings/globals'/>
+/// <reference types='@gitpod/gitpod-protocol/lib/typings/globals.d.ts'/>
 
-import type { IDEFrontendState } from '@gitpod/gitpod-protocol/lib/ide-frontend-service';
-import type { Status, TunnelStatus } from '@gitpod/local-app-api-grpcweb';
+import type { IDEFrontendState } from '@gitpod/gitpod-protocol/lib/ide-frontend-service.js';
+import type { Status, TunnelStatus } from '@gitpod/local-app-api-grpcweb/lib/localapp.d.ts';
 import { isStandalone } from '../../../base/browser/browser.js';
 import { parse } from '../../../base/common/marshalling.js';
 import { Emitter, Event } from '../../../base/common/event.js';
@@ -32,7 +32,7 @@ import type { TunnelOptions } from 'vscode';
 import { importAMDNodeModule } from '../../../amdX.js';
 import { mainWindow } from '../../../base/browser/window.js';
 
-const loadingGrpc = importAMDNodeModule<typeof import('@improbable-eng/grpc-web')>('@improbable-eng/grpc-web', 'dist/grpc-web-client.umd.js');
+const loadingGrpc = importAMDNodeModule<typeof import('@improbable-eng/grpc-web/dist/typings/index.d.ts')>('@improbable-eng/grpc-web', 'dist/grpc-web-client.umd.js');
 
 export class LocalStorageSecretStorageProvider implements ISecretStorageProvider {
 	private readonly _storageKey = 'secrets.provider';

src/vs/gitpod/common/insightsHelper.ts

@@ -4,7 +4,7 @@
  *  Copyright (c) Gitpod. All rights reserved.
  *--------------------------------------------------------------------------------------------*/
 
-import type { IDEMetric } from '@gitpod/ide-metrics-api-grpcweb/lib/index';
+import type { IDEMetric } from '@gitpod/ide-metrics-api-grpcweb/lib/index.js';
 
 export interface ReportErrorParam {
 	workspaceId: string;
@@ -216,6 +216,7 @@ export function mapTelemetryData(source: 'window' | 'remote-server', eventName:
 			};
 			return {
 				event: 'vscode_browser_remote_connection',
+				// eslint-disable-next-line local/code-no-dangerous-type-assertions
 				properties: {
 					state: getEventName(eventName),
 					// Time, in ms, until connected / connection failure
@@ -231,6 +232,7 @@ export function mapTelemetryData(source: 'window' | 'remote-server', eventName:
 			};
 			return {
 				event: 'vscode_browser_remote_connection_latency',
+				// eslint-disable-next-line local/code-no-dangerous-type-assertions
 				properties: {
 					latencyMs: data.latencyMs
 				} as ConnectionLatencyProperties
@@ -250,6 +252,7 @@ export function mapTelemetryData(source: 'window' | 'remote-server', eventName:
 			};
 			return {
 				event: 'vscode_browser_remote_reconnection',
+				// eslint-disable-next-line local/code-no-dangerous-type-assertions
 				properties: {
 					event: getEventName(eventName),
 					reconnectionToken: data.reconnectionToken,

src/vs/server/node/remoteExtensionsScanner.ts

@@ -44,7 +44,7 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS
 		private readonly _logService: ILogService,
 		private readonly _extensionGalleryService: IExtensionGalleryService,
 		private readonly _languagePackService: ILanguagePackService,
-		private readonly _extensionManagementService: IExtensionManagementService,,
+		private readonly _extensionManagementService: IExtensionManagementService,
 		private readonly _downloadService: IDownloadService,
 	) {
 		const builtinExtensionsToInstall = environmentService.args['install-builtin-extension'];