Skip to content

Commit 36336a5

Browse files
jeanp413mustard-mh
authored andcommitted
Fixes
Tool: gitpod/catfood.gitpod.cloud
1 parent 6aba26a commit 36336a5

File tree

6 files changed

+5
-75
lines changed

6 files changed

+5
-75
lines changed

.gitpod.Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,3 @@ RUN sudo apt-get update \
1919
libasound2 libgbm1 xfonts-base xfonts-terminus fonts-noto fonts-wqy-microhei \
2020
fonts-droid-fallback vim-tiny nano libgconf2-dev libgtk-3-dev twm \
2121
&& sudo apt-get clean && sudo rm -rf /var/cache/apt/* && sudo rm -rf /var/lib/apt/lists/* && sudo rm -rf /tmp/*
22-
23-
# Disable v8 cache used by yarn v1.x, refs https://github.com/nodejs/node/issues/51555
24-
ENV DISABLE_V8_COMPILE_CACHE=1

package-lock.json

Lines changed: 0 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
"unlink:gitpod-web": "rm extensions/gitpod-web"
7272
},
7373
"dependencies": {
74-
"@bpasero/watcher": "https://github.com/bpasero/watcher.git#3e5e50c275590703f3eb46fac777b720e515d0d5",
7574
"@gitpod/gitpod-protocol": "main-gha",
7675
"@gitpod/ide-metrics-api-grpcweb": "main-gha",
7776
"@gitpod/local-app-api-grpcweb": "^0.1.5-hw-fix-code-nightly-gha.29105",

remote/package-lock.json

Lines changed: 2 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

remote/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"version": "0.0.0",
44
"private": true,
55
"dependencies": {
6-
"@bpasero/watcher": "https://github.com/bpasero/watcher.git#3e5e50c275590703f3eb46fac777b720e515d0d5",
76
"@gitpod/gitpod-protocol": "main-gha",
87
"@gitpod/ide-metrics-api-grpcweb": "main-gha",
98
"@gitpod/supervisor-api-grpc": "main-gha",

src/vs/gitpod/browser/gitpodInsightsAppender.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import type { IDEMetric } from '@gitpod/ide-metrics-api-grpcweb';
1111
import type { ErrorEvent } from '../../platform/telemetry/common/errorTelemetry.js';
1212
import { IGitpodPreviewConfiguration } from '../../base/common/product.js';
1313
import { filter } from '../../base/common/objects.js';
14-
// eslint-disable-next-line local/code-amd-node-module
1514
import type { Analytics, AnalyticsSettings } from '@jeanp413/analytics-node-umd';
1615
import { importAMDNodeModule } from '../../amdX.js';
16+
import { mainWindow } from '../../base/browser/window.js';
1717

1818
const segmentResolver = importAMDNodeModule<typeof import('@jeanp413/analytics-node-umd')>('@jeanp413/analytics-node-umd', 'dist/umd/index.js');
1919

@@ -153,7 +153,7 @@ export class GitpodInsightsAppender implements ITelemetryAppender {
153153
const params: ReportErrorParam = {
154154
workspaceId: gitpodWsInfo.workspaceId,
155155
instanceId: gitpodWsInfo.instanceId,
156-
userId: window.gitpod.loggedUserID || gitpodWsInfo.ownerId,
156+
userId: mainWindow.gitpod.loggedUserID || gitpodWsInfo.ownerId,
157157
errorStack: error.callstack,
158158
component: 'vscode-web',
159159
version: this.productVersion,
@@ -191,7 +191,6 @@ export class GitpodInsightsAppender implements ITelemetryAppender {
191191
}
192192
// load grpc-web before see https://github.com/gitpod-io/gitpod/issues/4448
193193
await importAMDNodeModule<typeof import('@improbable-eng/grpc-web')>('@improbable-eng/grpc-web', 'dist/grpc-web-client.umd.js');
194-
// eslint-disable-next-line local/code-amd-node-module
195194

196195
const MetricsServiceClient = (await importAMDNodeModule<typeof import('@gitpod/ide-metrics-api-grpcweb')>('@gitpod/ide-metrics-api-grpcweb', 'lib/idemetrics_grpc_web_pb.js')).MetricsServiceClient;
197196
const sendMetrics = (await importAMDNodeModule<typeof import('@gitpod/ide-metrics-api-grpcweb')>('@gitpod/ide-metrics-api-grpcweb', 'lib/index.js')).sendMetrics;
@@ -211,7 +210,7 @@ export class GitpodInsightsAppender implements ITelemetryAppender {
211210
private async getWorkspaceInfo() {
212211
if (!this._workspaceInfo) {
213212
this._workspaceInfo = (async () => {
214-
const infoResponse = await fetch(window.location.protocol + '//' + window.location.host + '/_supervisor/v1/info/workspace', {
213+
const infoResponse = await fetch(mainWindow.location.protocol + '//' + mainWindow.location.host + '/_supervisor/v1/info/workspace', {
215214
credentials: 'include'
216215
});
217216
if (!infoResponse.ok) {

0 commit comments

Comments
 (0)