Skip to content

add .editorconfig file #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025
Merged

Conversation

Fatpandac
Copy link
Contributor

It changes the following:

  • add .editorconfig file

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst extrawurst requested a review from naseschwarz March 15, 2025 09:14
Copy link
Contributor

@naseschwarz naseschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR.

I tested this and it works fine in neovim and editorconfig-checker. The latter finds a lot of misformats from rustfmt, so I think it's a good idea to have an .editorconfig in order to avoid these in the first place!

image

(I'll follow up with the rustfmt project and the hard_tabs issue separately.)

@Fatpandac Fatpandac requested a review from naseschwarz March 16, 2025 04:01
@extrawurst
Copy link
Collaborator

Thanks for the contribution! I am going to merge this without a changelog because it’s not end-user facing but ideally we add changelogs for even dx changes 👍

@extrawurst extrawurst merged commit 1f3bd0f into gitui-org:master Mar 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants