Skip to content

Add --logfile #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2025
Merged

Add --logfile #2539

merged 4 commits into from
Mar 16, 2025

Conversation

acuteenvy
Copy link
Contributor

Add a command-line option to override the default log file path.

gitui --logging stays unchanged;
gitui --logfile path/to/file.log logs to path/to/file.log;
gitui --logging --logfile path/to/file.log is equivalent to using just --logfile.

This Pull Request fixes/closes #2528.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Add a command-line option to override the default log file path.
@cruessler
Copy link
Collaborator

@extrawurst I can have a look at this PR this week!

Copy link
Collaborator

@cruessler cruessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@extrawurst I reviewed the PR on my Ubuntu machine and noticed two things:

  • I was wondering whether --logfile needed the short version -f as the latter conventionally also is short for --force.
  • The PR contains spaces instead of tabs, as far as I can see in my editor, but cargo fmt doesn’t seem to complain, neither on my machine nor on CI.

Otherwise, I’d say this is good to go!

@acuteenvy acuteenvy changed the title Add -f, --logfile Add --logfile Mar 12, 2025
@extrawurst extrawurst merged commit 4ccdeed into gitui-org:master Mar 16, 2025
21 checks passed
@acuteenvy acuteenvy deleted the override-logfile branch March 16, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command-line option to override the default log file path
3 participants