[benchmark] Don't create array instance in modules with solitary benchmarks

It just produces unnecessary code sign churn.

Author: lorentey

benchmark/single-source/Ackermann.swift

@@ -14,12 +14,11 @@
 // for performance measuring.
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Ackermann",
     runFunction: run_Ackermann,
-    tags: [.algorithm]),
-]
+    tags: [.algorithm])
 
 func _ackermann(_ m: Int, _ n : Int) -> Int {
   if (m == 0) { return n + 1 }

benchmark/single-source/AnyHashableWithAClass.swift

@@ -22,14 +22,13 @@ import TestsUtils
 // 11% _swift_stdlib_makeAnyHashableUpcastingToHashableBaseType
 // 16% _swift_retain_[n]
 //  5% swift_conformsToProtocol
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "AnyHashableWithAClass",
     runFunction: run_AnyHashableWithAClass,
     tags: [.abstraction, .runtime, .cpubench],
     legacyFactor: 500
-  ),
-]
+  )
 
 class TestHashableBase : Hashable {
   var value: Int

benchmark/single-source/Array2D.swift

@@ -12,15 +12,14 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Array2D",
     runFunction: run_Array2D,
     tags: [.validation, .api, .Array],
     setUpFunction: { blackHole(inputArray) },
     tearDownFunction: { inputArray = nil },
-    legacyFactor: 16),
-]
+    legacyFactor: 16)
 
 let size = 256
 

benchmark/single-source/ArrayOfGenericRef.swift

@@ -17,13 +17,12 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ArrayOfGenericRef",
     runFunction: run_ArrayOfGenericRef,
     tags: [.validation, .api, .Array],
     legacyFactor: 10)
-]
 
 protocol Constructible {
   associatedtype Element

benchmark/single-source/ArrayOfPOD.swift

@@ -18,12 +18,11 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ArrayOfPOD",
     runFunction: run_ArrayOfPOD,
     tags: [.validation, .api, .Array])
-]
 
 class RefArray<T> {
   var array : [T]

benchmark/single-source/ArrayOfRef.swift

@@ -18,13 +18,12 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ArrayOfRef",
     runFunction: run_ArrayOfRef,
     tags: [.validation, .api, .Array],
     legacyFactor: 10)
-]
 
 protocol Constructible {
   associatedtype Element

benchmark/single-source/ArraySetElement.swift

@@ -15,13 +15,12 @@ import TestsUtils
 // 33% isUniquelyReferenced
 //   15% swift_rt_swift_isUniquelyReferencedOrPinned_nonNull_native
 //   18% swift_isUniquelyReferencedOrPinned_nonNull_native
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ArraySetElement",
     runFunction: run_ArraySetElement,
     tags: [.runtime, .cpubench]
-  ),
-]
+  )
 
 // This is an effort to defeat isUniquelyReferenced optimization. Ideally
 // microbenchmarks list this should be written in C.

benchmark/single-source/ArraySubscript.swift

@@ -13,13 +13,12 @@
 // This test checks the performance of modifying an array element.
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ArraySubscript",
     runFunction: run_ArraySubscript,
     tags: [.validation, .api, .Array],
-    legacyFactor: 4),
-]
+    legacyFactor: 4)
 
 @inline(never)
 public func run_ArraySubscript(_ n: Int) {

benchmark/single-source/BitCount.swift

@@ -15,12 +15,11 @@
 // rdar://problem/22151678
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "BitCount",
     runFunction: run_BitCount,
-    tags: [.validation, .algorithm]),
-]
+    tags: [.validation, .algorithm])
 
 func countBitSet(_ num: Int) -> Int {
   let bits = MemoryLayout<Int>.size * 8

benchmark/single-source/BucketSort.swift

@@ -27,14 +27,13 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "BucketSort",
     runFunction: run_BucketSort,
     tags: [.validation, .algorithm],
     setUpFunction: { blackHole(buckets) }
-  ),
-]
+  )
 
 public protocol IntegerConvertible {
     func convertToInt() -> Int

benchmark/single-source/ByteSwap.swift

@@ -15,12 +15,11 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ByteSwap",
     runFunction: run_ByteSwap,
-    tags: [.validation, .algorithm]),
-]
+    tags: [.validation, .algorithm])
 
 // a naive O(n) implementation of byteswap.
 @inline(never)

benchmark/single-source/COWArrayGuaranteedParameterOverhead.swift

@@ -15,14 +15,13 @@ import TestsUtils
 // This test makes sure that even though we have +0 arguments by default that we
 // can properly convert +0 -> +1 to avoid extra COW copies.
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "COWArrayGuaranteedParameterOverhead",
     runFunction: run_COWArrayGuaranteedParameterOverhead,
     tags: [.regression, .abstraction, .refcount],
     legacyFactor: 50
-  ),
-]
+  )
 
 @inline(never)
 func caller() {

benchmark/single-source/Calculator.swift

@@ -12,12 +12,11 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Calculator",
     runFunction: run_Calculator,
     tags: [.validation])
-]
 
 @inline(never)
 func my_atoi_impl(_ input : String) -> Int {

benchmark/single-source/CaptureProp.swift

@@ -12,13 +12,12 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "CaptureProp",
     runFunction: run_CaptureProp,
     tags: [.validation, .api, .refcount],
-    legacyFactor: 10),
-]
+    legacyFactor: 10)
 
 func sum(_ x:Int, y:Int) -> Int {
   return x + y

benchmark/single-source/CharacterLiteralsLarge.swift

@@ -15,12 +15,11 @@
 // and retain a StringBuffer.
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "CharacterLiteralsLarge",
     runFunction: run_CharacterLiteralsLarge,
     tags: [.validation, .api, .String])
-]
 
 @inline(never)
 func makeCharacter_UTF8Length9() -> Character {

benchmark/single-source/CharacterLiteralsSmall.swift

@@ -15,12 +15,11 @@
 // represented as a packed integer.
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "CharacterLiteralsSmall",
     runFunction: run_CharacterLiteralsSmall,
-    tags: [.validation, .api, .String]),
-]
+    tags: [.validation, .api, .String])
 
 @inline(never)
 func makeCharacter_UTF8Length1() -> Character {

benchmark/single-source/Chars.swift

@@ -13,14 +13,13 @@
 // This test tests the performance of ASCII Character comparison.
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Chars2",
     runFunction: run_Chars,
     tags: [.validation, .api, .String],
     setUpFunction: { blackHole(alphabetInput) },
-    legacyFactor: 50),
-]
+    legacyFactor: 50)
 
 let alphabetInput: [Character] = [
     "A", "B", "C", "D", "E", "F", "G",

benchmark/single-source/ClassArrayGetter.swift

@@ -12,15 +12,14 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ClassArrayGetter2",
     runFunction: run_ClassArrayGetter,
     tags: [.validation, .api, .Array],
     setUpFunction: { blackHole(inputArray) },
     tearDownFunction: { inputArray = nil },
-    legacyFactor: 10),
-]
+    legacyFactor: 10)
 
 class Box {
   var v: Int

benchmark/single-source/Combos.swift

@@ -5,13 +5,12 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Combos",
     runFunction: run_Combos,
     tags: [.validation, .abstraction]
-  ),
-]
+  )
 
 @inline(never)
 public func run_Combos(_ n: Int) {

benchmark/single-source/DeadArray.swift

@@ -13,14 +13,13 @@
 // rdar://problem/20980377
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "DeadArray",
     runFunction: run_DeadArray,
     tags: [.regression, .unstable],
     legacyFactor: 200
-  ),
-]
+  )
 
 @inline(__always)
 func debug(_ m:String) {}

benchmark/single-source/DictionaryBridge.swift

@@ -16,12 +16,11 @@
 import Foundation
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "DictionaryBridge",
     runFunction: run_DictionaryBridge,
-    tags: [.validation, .api, .Dictionary, .bridging]),
-]
+    tags: [.validation, .api, .Dictionary, .bridging])
 
 #if _runtime(_ObjC)
 class Thing : NSObject {

benchmark/single-source/DiffingMyers.swift

@@ -16,13 +16,12 @@ import TestsUtils
 // described in Myers (1986). The Diffing benchmark tracks the performance
 // of `Collection.difference(from:to:)`.
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Diffing.Myers.Similar",
     runFunction: run_Myers,
     tags: [.algorithm],
     setUpFunction: { blackHole((loremIpsum, unabridgedLorem)) })
-]
 
 
 let loremIpsum = Array("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.")

benchmark/single-source/ErrorHandling.swift

@@ -12,13 +12,12 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "ErrorHandling",
     runFunction: run_ErrorHandling,
     tags: [.validation, .exceptions],
-    legacyFactor: 10),
-]
+    legacyFactor: 10)
 
 enum PizzaError : Error {
   case Pepperoni, Olives, Anchovy

benchmark/single-source/Fibonacci.swift

@@ -12,12 +12,11 @@
 
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Fibonacci",
     runFunction: run_Fibonacci,
     tags: [.algorithm])
-]
 
 func _fibonacci(_ n: Int) -> Int {
   if (n <= 2) { return 1 }

benchmark/single-source/Hanoi.swift

@@ -14,13 +14,12 @@
 // <rdar://problem/22151932>
 import TestsUtils
 
-public let benchmarks = [
+public let benchmarks =
   BenchmarkInfo(
     name: "Hanoi",
     runFunction: run_Hanoi,
     tags: [.validation, .algorithm],
-    legacyFactor: 10),
-]
+    legacyFactor: 10)
 
 struct Move {
    var from: String