fix 500 error when view an issue which's milestone deleted (#2297) (#2299)

lunny · web-flow · commit 09fff9e1c194 · 2017-08-14T10:45:06.000+08:00
diff --git a/models/issue.go b/models/issue.go
@@ -146,7 +146,7 @@ func (issue *Issue) loadAttributes(e Engine) (err error) {
 
 	if issue.Milestone == nil && issue.MilestoneID > 0 {
 		issue.Milestone, err = getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)
-		if err != nil {
+		if err != nil && !IsErrMilestoneNotExist(err) {
 			return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %v", issue.RepoID, issue.MilestoneID, err)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ func (issue *Issue) loadAttributes(e Engine) (err error) {`
`146`	`146`
`147`	`147`	`if issue.Milestone == nil && issue.MilestoneID > 0 {`
`148`	`148`	`issue.Milestone, err = getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)`
`149`		`- if err != nil {`
	`149`	`+ if err != nil && !IsErrMilestoneNotExist(err) {`
`150`	`150`	`return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %v", issue.RepoID, issue.MilestoneID, err)`
`151`	`151`	`}`
`152`	`152`	`}`