Skip to content

Commit 0bba3f9

Browse files
authored
Various dark theme fixes (#10416)
- beatify simplemde, remove header hover effect (does not play well with border colors), remove double border separators - fix colored outline buttons - fix disabled style - fix positive messages - fix markdown header border and quote block - adjust footer color - adjust file icons and release list timeline
1 parent fe26ca5 commit 0bba3f9

File tree

2 files changed

+71
-11
lines changed

2 files changed

+71
-11
lines changed

web_src/less/_editor.less

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,11 @@
2424
border-right: 0;
2525
border-bottom: 0;
2626
}
27+
28+
.editor-toolbar {
29+
opacity: 1 !important;
30+
}
31+
32+
.editor-toolbar i.separator {
33+
border-left: none;
34+
}

web_src/less/themes/theme-arc-green.less

Lines changed: 63 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ a:hover {
245245
footer {
246246
background: #2e323e;
247247
border-top: 1px solid #313131;
248+
color: #bababa;
248249
}
249250

250251
.ui.menu .dropdown.item .menu {
@@ -345,7 +346,7 @@ a.ui.basic.green.label:hover {
345346

346347
.ui.basic.button,
347348
.ui.basic.buttons .button {
348-
color: #797979 !important;
349+
color: #797979;
349350
}
350351

351352
.ui.basic.red.active.button,
@@ -358,8 +359,9 @@ a.ui.basic.green.label:hover {
358359
.ui.basic.button:hover,
359360
.ui.basic.buttons .button:focus,
360361
.ui.basic.buttons .button:hover {
361-
background: transparent !important;
362-
color: #dbdbdb !important;
362+
color: #dbdbdb;
363+
box-shadow: 0 0 0 1px rgba(200, 200, 200, 0.35) inset;
364+
background: rgba(0, 0, 0, 0.5);
363365
}
364366

365367
.ui.menu .item {
@@ -368,7 +370,9 @@ a.ui.basic.green.label:hover {
368370
}
369371

370372
.ui.menu .item.disabled,
371-
.ui.menu .item.disabled:hover {
373+
.ui.menu .item.disabled:hover,
374+
.ui.ui.menu .item.disabled,
375+
.ui.ui.menu .item.disabled:hover {
372376
color: #626773;
373377
}
374378

@@ -515,7 +519,7 @@ a.ui.basic.green.label:hover {
515519
}
516520

517521
.ui .text.grey {
518-
color: #808084 !important;
522+
color: #a5a5a8 !important;
519523
}
520524

521525
.ui.attached.table.segment {
@@ -669,7 +673,12 @@ a.ui.basic.green.label:hover {
669673
}
670674

671675
.ui.comments .comment .actions a {
672-
color: #dbdbdb;
676+
color: #9e9e9e;
677+
}
678+
679+
.ui.comments .comment .actions a.active,
680+
.ui.comments .comment .actions a:hover {
681+
color: #fff;
673682
}
674683

675684
.repository.view.issue .comment-list .comment .content .header:after {
@@ -708,6 +717,7 @@ a.ui.basic.green.label:hover {
708717
.ui.basic.green.active.button,
709718
.ui.basic.green.buttons .active.button {
710719
color: #13ae38 !important;
720+
box-shadow: 0 0 0 1px #13ae38 inset !important;
711721
}
712722

713723
.ui.form textarea,
@@ -1019,6 +1029,12 @@ input {
10191029
color: #9e9e9e;
10201030
}
10211031

1032+
.ui.positive.message {
1033+
background-color: #0d491b;
1034+
color: #87ab63;
1035+
box-shadow: 0 0 0 1px #2d693b inset, 0 0 0 0 transparent;
1036+
}
1037+
10221038
.ui.negative.message {
10231039
background-color: rgba(80, 23, 17, 0.6);
10241040
color: #f9cbcb;
@@ -1212,10 +1228,21 @@ a.ui.labels .label:hover {
12121228

12131229
.editor-toolbar {
12141230
background-color: #404552;
1231+
border-color: #7f98ad;
1232+
}
12151233

1216-
a {
1217-
color: #87ab63 !important;
1218-
}
1234+
.editor-toolbar a {
1235+
color: #87ab63 !important;
1236+
}
1237+
1238+
.editor-toolbar a.active,
1239+
.editor-toolbar a:hover {
1240+
background: #2a2e3a;
1241+
border-color: transparent;
1242+
}
1243+
1244+
.editor-toolbar i.separator {
1245+
border-right-color: #7f98ad;
12191246
}
12201247

12211248
.repository .diff-detail-box {
@@ -1369,15 +1396,16 @@ a.ui.labels .label:hover {
13691396

13701397
.CodeMirror {
13711398
color: #9daccc;
1372-
background-color: #2b2b2b;
1399+
background-color: #2e323e;
1400+
border-color: #7f98ad;
13731401
border-top: 0;
13741402

13751403
div.CodeMirror-cursor {
13761404
border-left: 1px solid #9e9e9e;
13771405
}
13781406

13791407
.CodeMirror-gutters {
1380-
background-color: #2b2b2b;
1408+
background-color: #2e323e;
13811409
}
13821410

13831411
::selection,
@@ -1485,3 +1513,27 @@ a.ui.labels .label:hover {
14851513
background-color: #383c4a;
14861514
}
14871515
}
1516+
1517+
.markdown:not(code) h1 {
1518+
border-bottom-color: #888;
1519+
}
1520+
1521+
.markdown:not(code) blockquote {
1522+
border-left-color: #888;
1523+
}
1524+
1525+
footer .container .links > * {
1526+
border-left-color: #888;
1527+
}
1528+
1529+
.repository.file.list #repo-files-table tbody .svg {
1530+
color: #9e9e9e;
1531+
}
1532+
1533+
.repository.release #release-list > li .detail {
1534+
border-left-color: #888;
1535+
}
1536+
1537+
.repository.release #release-list > li .detail .dot {
1538+
background-color: #888;
1539+
}

0 commit comments

Comments
 (0)