Do not allow deleting protected branch

Author: lafriks

routers/repo/issue.go

@@ -651,8 +651,13 @@ func ViewIssue(ctx *context.Context) {
 			if err := pull.GetHeadRepo(); err != nil {
 				log.Error(4, "GetHeadRepo: %v", err)
 			} else if pull.HeadBranch != pull.HeadRepo.DefaultBranch && ctx.User.IsWriterOfRepo(pull.HeadRepo) {
-				canDelete = true
-				ctx.Data["DeleteBranchLink"] = ctx.Repo.RepoLink + "/pulls/" + com.ToStr(issue.Index) + "/cleanup"
+				// Check if branch is not protected
+				if protected, err := pull.HeadRepo.IsProtectedBranch(pull.HeadBranch); err != nil {
+					log.Error(4, "IsProtectedBranch: %v", err)
+				} else if !protected {
+					canDelete = true
+					ctx.Data["DeleteBranchLink"] = ctx.Repo.RepoLink + "/pulls/" + com.ToStr(issue.Index) + "/cleanup"
+				}
 			}
 		}
 

routers/repo/pull.go

@@ -788,7 +788,7 @@ func CleanUpPullRequest(ctx *context.Context) {
 		ctx.Handle(500, "GetBaseRepo", err)
 		return
 	} else if pr.HeadRepo.GetOwner(); err != nil {
-		ctx.Handle(500, "GetOwner", err)
+		ctx.Handle(500, "HeadRepo.GetOwner", err)
 		return
 	}
 
@@ -822,6 +822,15 @@ func CleanUpPullRequest(ctx *context.Context) {
 		return
 	}
 
+	// Check if branch is not protected
+	if protected, err := pr.HeadRepo.IsProtectedBranch(pr.HeadBranch); err != nil || protected {
+		if err != nil {
+			log.Error(4, "HeadRepo.IsProtectedBranch: %v", err)
+		}
+		ctx.Flash.Error(ctx.Tr("repo.branch.deletion_failed", fullBranchName))
+		return
+	}
+
 	// Check if branch has no new commits
 	if len(pr.MergedCommitID) > 0 {
 		branchCommitID, err := gitRepo.GetBranchCommitID(pr.HeadBranch)