MilestoneList: add name as filter on API

Author: 6543

models/issue_milestone.go

@@ -335,33 +335,28 @@ type GetMilestonesOption struct {
 	ListOptions
 	RepoID   int64
 	State    api.StateType
+	Name     string
 	SortType string
 }
 
 // GetMilestones returns milestones filtered by GetMilestonesOption's
 func GetMilestones(opts GetMilestonesOption) (MilestoneList, error) {
-	sess := x.NewSession()
-	defer sess.Close()
-	if err := sess.Begin(); err != nil {
-		return nil, err
-	}
-
-	if opts.RepoID != 0 {
-		sess = sess.Where("repo_id = ?", opts.RepoID)
-	}
+	sess := x.Where("repo_id = ?", opts.RepoID)
 
 	switch opts.State {
 	case api.StateClosed:
 		sess = sess.And("is_closed = ?", true)
-
 	case api.StateAll:
 		break
-
 	// api.StateOpen:
 	default:
 		sess = sess.And("is_closed = ?", false)
 	}
 
+	if len(opts.Name) != 0 {
+		sess = sess.And(builder.Like{"name", opts.Name})
+	}
+
 	if opts.Page != 0 {
 		sess = opts.setSessionPagination(sess)
 	}

routers/api/v1/repo/milestone.go

@@ -39,6 +39,10 @@ func ListMilestones(ctx *context.APIContext) {
 	//   in: query
 	//   description: Milestone state, Recognised values are open, closed and all. Defaults to "open"
 	//   type: string
+	// - name: name
+	//   in: query
+	//   description: filter by milestone name
+	//   type: string
 	// - name: page
 	//   in: query
 	//   description: page number of results to return (1-based)
@@ -55,6 +59,7 @@ func ListMilestones(ctx *context.APIContext) {
 		ListOptions: utils.GetListOptions(ctx),
 		RepoID:      ctx.Repo.Repository.ID,
 		State:       api.StateType(ctx.Query("state")),
+		Name:        ctx.Query("name"),
 	})
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "GetMilestones", err)

templates/swagger/v1_json.tmpl

@@ -6164,6 +6164,12 @@
             "name": "state",
             "in": "query"
           },
+          {
+            "type": "string",
+            "description": "filter by milestone name",
+            "name": "name",
+            "in": "query"
+          },
           {
             "type": "integer",
             "description": "page number of results to return (1-based)",