Set the initial commit status to Success otherwise it will always be Pending (#10317) (#10318)

zeripath · web-flow · commit 117dcf1c02b6 · 2020-02-17T20:50:59.000Z
Backport #10317 The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go
@@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
 		return structs.CommitStatusSuccess
 	}
 
-	var returnedStatus = structs.CommitStatusPending
+	var returnedStatus = structs.CommitStatusSuccess
 	for _, ctx := range requiredContexts {
 		var targetStatus structs.CommitStatusState
 		for _, commitStatus := range commitStatuses {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re`
`23`	`23`	`return structs.CommitStatusSuccess`
`24`	`24`	`}`
`25`	`25`
`26`		`- var returnedStatus = structs.CommitStatusPending`
	`26`	`+ var returnedStatus = structs.CommitStatusSuccess`
`27`	`27`	`for _, ctx := range requiredContexts {`
`28`	`28`	`var targetStatus structs.CommitStatusState`
`29`	`29`	`for _, commitStatus := range commitStatuses {`