Move interpolation logic to jobparser, add helper ToGitHubContext, reorder DispatchActionWorkflow to support run-name parsing

Author: badhezi

go.mod

@@ -317,7 +317,7 @@ replace github.com/hashicorp/go-version => github.com/6543/go-version v1.3.1
 
 replace github.com/shurcooL/vfsgen => github.com/lunny/vfsgen v0.0.0-20220105142115-2c99e1ffdfa0
 
-replace github.com/nektos/act => gitea.com/badhezi/act v0.0.0-20250429095415-d27028e1df50
+replace github.com/nektos/act => gitea.com/badhezi/act v0.0.0-20250501202946-5f2de4d09b1f
 
 // TODO: the only difference is in `PutObject`: the fork doesn't use `NewVerifyingReader(r, sha256.New(), oid, expectedSize)`, need to figure out why
 replace github.com/charmbracelet/git-lfs-transfer => gitea.com/gitea/git-lfs-transfer v0.2.0

go.sum

@@ -16,6 +16,10 @@ filippo.io/edwards25519 v1.1.0 h1:FNf4tywRC1HmFuKW5xopWpigGjJKiJSV0Cqo0cJWDaA=
 filippo.io/edwards25519 v1.1.0/go.mod h1:BxyFTGdWcka3PhytdK4V28tE5sGfRvvvRV7EaN4VDT4=
 gitea.com/badhezi/act v0.0.0-20250429095415-d27028e1df50 h1:46UPmv+pLMBd2TR/N/hKpWY3SloOlVusmZg6SmpcfbE=
 gitea.com/badhezi/act v0.0.0-20250429095415-d27028e1df50/go.mod h1:Pg5C9kQY1CEA3QjthjhlrqOC/QOT5NyWNjOjRHw23Ok=
+gitea.com/badhezi/act v0.0.0-20250501200956-eaed3ad12395 h1:LWYeTtkf2cBhRNPqXrIPxMOlH3EmvU6EyKyqzf66hM0=
+gitea.com/badhezi/act v0.0.0-20250501200956-eaed3ad12395/go.mod h1:Pg5C9kQY1CEA3QjthjhlrqOC/QOT5NyWNjOjRHw23Ok=
+gitea.com/badhezi/act v0.0.0-20250501202946-5f2de4d09b1f h1:aPHa4bpjOgUGJoMkQZ5PvpASmrjHLx55sIu+RtGWzvE=
+gitea.com/badhezi/act v0.0.0-20250501202946-5f2de4d09b1f/go.mod h1:Pg5C9kQY1CEA3QjthjhlrqOC/QOT5NyWNjOjRHw23Ok=
 gitea.com/gitea/git-lfs-transfer v0.2.0 h1:baHaNoBSRaeq/xKayEXwiDQtlIjps4Ac/Ll4KqLMB40=
 gitea.com/gitea/git-lfs-transfer v0.2.0/go.mod h1:UrXUCm3xLQkq15fu7qlXHUMlrhdlXHoi13KH2Dfiits=
 gitea.com/gitea/go-xsd-duration v0.0.0-20220703122237-02e73435a078 h1:BAFmdZpRW7zMQZQDClaCWobRj9uL1MR3MzpCVJvc5s4=

services/actions/context.go

@@ -14,12 +14,17 @@ import (
 	"code.gitea.io/gitea/modules/container"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/json"
+	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/setting"
+
+	"github.com/nektos/act/pkg/model"
 )
 
+type GiteaContext map[string]any
+
 // GenerateGiteaContext generate the gitea context without token and gitea_runtime_token
 // job can be nil when generating a context for parsing workflow-level expressions
-func GenerateGiteaContext(run *actions_model.ActionRun, job *actions_model.ActionRunJob) map[string]any {
+func GenerateGiteaContext(run *actions_model.ActionRun, job *actions_model.ActionRunJob) GiteaContext {
 	event := map[string]any{}
 	_ = json.Unmarshal([]byte(run.EventPayload), &event)
 
@@ -42,7 +47,7 @@ func GenerateGiteaContext(run *actions_model.ActionRun, job *actions_model.Actio
 
 	refName := git.RefName(ref)
 
-	gitContext := map[string]any{
+	gitContext := GiteaContext{
 		// standard contexts, see https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
 		"action":            "",                                       // string, The name of the action currently running, or the id of a step. GitHub removes special characters, and uses the name __run when the current step runs a script without an id. If you use the same action more than once in the same job, the name will include a suffix with the sequence number with underscore before it. For example, the first script you run will have the name __run, and the second script will be named __run_2. Similarly, the second invocation of actions/checkout will be actionscheckout2.
 		"action_path":       "",                                       // string, The path where an action is located. This property is only supported in composite actions. You can use this path to access files located in the same repository as the action.
@@ -160,3 +165,19 @@ func mergeTwoOutputs(o1, o2 map[string]string) map[string]string {
 	}
 	return ret
 }
+
+func (g *GiteaContext) ToGitHubContext() *model.GithubContext {
+	ghCtx := &model.GithubContext{}
+
+	gitCtxRaw, err := json.Marshal(g)
+	if err != nil {
+		log.Error("ToGitHubContext.json.Marshal: %v", err)
+	}
+
+	err = json.Unmarshal(gitCtxRaw, ghCtx)
+	if err != nil {
+		log.Error("ToGitHubContext.json.Unmarshal: %v", err)
+	}
+
+	return ghCtx
+}

services/actions/notifier_helper.go

@@ -316,10 +316,6 @@ func handleWorkflows(
 			Status:            actions_model.StatusWaiting,
 		}
 
-		if runName, err := parseRunName(run, dwf); err == nil {
-			run.Title = runName
-		}
-
 		need, err := ifNeedApproval(ctx, run, input.Repo, input.Doer)
 		if err != nil {
 			log.Error("check if need approval for repo %d with user %d: %v", input.Repo.ID, input.Doer.ID, err)
@@ -339,12 +335,18 @@ func handleWorkflows(
 			continue
 		}
 
-		jobs, err := jobparser.Parse(dwf.Content, jobparser.WithVars(vars))
+		giteaCtx := GenerateGiteaContext(run, nil)
+
+		jobs, err := jobparser.Parse(dwf.Content, jobparser.WithVars(vars), jobparser.WithGitContext(giteaCtx.ToGitHubContext()))
 		if err != nil {
 			log.Error("jobparser.Parse: %v", err)
 			continue
 		}
 
+		if len(jobs) > 0 && jobs[0].RunName != "" {
+			run.Title = jobs[0].RunName
+		}
+
 		// cancel running jobs if the event is push or pull_request_sync
 		if run.Event == webhook_module.HookEventPush ||
 			run.Event == webhook_module.HookEventPullRequestSync {
@@ -527,8 +529,22 @@ func handleSchedules(
 			Content:       dwf.Content,
 		}
 
-		if runName, err := parseRunName(run.ToActionRun(), dwf); err == nil {
-			run.Title = runName
+		vars, err := actions_model.GetVariablesOfRun(ctx, run.ToActionRun())
+		if err != nil {
+			log.Error("GetVariablesOfRun: %v", err)
+			continue
+		}
+
+		giteaCtx := GenerateGiteaContext(run.ToActionRun(), nil)
+
+		jobs, err := jobparser.Parse(dwf.Content, jobparser.WithVars(vars), jobparser.WithGitContext(giteaCtx.ToGitHubContext()))
+		if err != nil {
+			log.Error("jobparser.Parse: %v", err)
+			continue
+		}
+
+		if len(jobs) > 0 && jobs[0].RunName != "" {
+			run.Title = jobs[0].RunName
 		}
 
 		crons = append(crons, run)
@@ -569,28 +585,3 @@ func DetectAndHandleSchedules(ctx context.Context, repo *repo_model.Repository)
 
 	return handleSchedules(ctx, scheduleWorkflows, commit, notifyInput, repo.DefaultBranch)
 }
-
-func parseRunName(r *actions_model.ActionRun, w *actions_module.DetectedWorkflow) (string, error) {
-	ghCtx := &model.GithubContext{}
-	gitCtx := GenerateGiteaContext(r, nil)
-
-	gitCtxRaw, err := json.Marshal(gitCtx)
-	if err != nil {
-		log.Error("NewInterpolatorForRun: %v", err)
-		return "", err
-	}
-
-	err = json.Unmarshal(gitCtxRaw, ghCtx)
-	if err != nil {
-		log.Error("NewInterpolatorForRun: %v", err)
-		return "", err
-	}
-
-	title, err := jobparser.ParseRunName(w.Content, jobparser.WithGitContext(ghCtx))
-	if err != nil {
-		// stay silent, run-name was not provided.
-		return "", err
-	}
-
-	return title, nil
-}

services/actions/workflow.go

@@ -192,27 +192,46 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 
 	// find workflow from commit
 	var workflows []*jobparser.SingleWorkflow
-	dwf := &actions.DetectedWorkflow{}
+	var entry *git.TreeEntry
 
-	for _, entry := range entries {
-		if entry.Name() != workflowID {
+	for _, e := range entries {
+		if e.Name() != workflowID {
 			continue
 		}
+		entry = e
+		break
+	}
 
-		content, err := actions.GetContentFromEntry(entry)
-		if err != nil {
-			return err
-		}
+	content, err := actions.GetContentFromEntry(entry)
+	if err != nil {
+		return err
+	}
 
-		workflows, err = jobparser.Parse(content)
-		if err != nil {
-			return err
-		}
+	run := &actions_model.ActionRun{
+		Title:             strings.SplitN(runTargetCommit.CommitMessage, "\n", 2)[0],
+		RepoID:            repo.ID,
+		Repo:              repo,
+		OwnerID:           repo.OwnerID,
+		WorkflowID:        workflowID,
+		TriggerUserID:     doer.ID,
+		TriggerUser:       doer,
+		Ref:               string(refName),
+		CommitSHA:         runTargetCommit.ID.String(),
+		IsForkPullRequest: false,
+		Event:             "workflow_dispatch",
+		TriggerEvent:      "workflow_dispatch",
+		Status:            actions_model.StatusWaiting,
+	}
 
-		dwf.Content = content
-		dwf.EntryName = entry.Name()
+	giteaCtx := GenerateGiteaContext(run, nil)
 
-		break
+	workflows, err = jobparser.Parse(content, jobparser.WithGitContext(giteaCtx.ToGitHubContext()))
+	if err != nil {
+		return err
+	}
+
+	if len(workflows) > 0 && workflows[0].RunName != "" {
+		run.Title = workflows[0].RunName
 	}
 
 	if len(workflows) == 0 {
@@ -243,33 +262,12 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 		Inputs:     inputsWithDefaults,
 		Sender:     convert.ToUserWithAccessMode(ctx, doer, perm.AccessModeNone),
 	}
+
 	var eventPayload []byte
 	if eventPayload, err = workflowDispatchPayload.JSONPayload(); err != nil {
 		return fmt.Errorf("JSONPayload: %w", err)
 	}
-
-	run := &actions_model.ActionRun{
-		Title:             strings.SplitN(runTargetCommit.CommitMessage, "\n", 2)[0],
-		RepoID:            repo.ID,
-		Repo:              repo,
-		OwnerID:           repo.OwnerID,
-		WorkflowID:        workflowID,
-		TriggerUserID:     doer.ID,
-		TriggerUser:       doer,
-		Ref:               string(refName),
-		CommitSHA:         runTargetCommit.ID.String(),
-		IsForkPullRequest: false,
-		Event:             "workflow_dispatch",
-		TriggerEvent:      "workflow_dispatch",
-		EventPayload:      string(eventPayload),
-		Status:            actions_model.StatusWaiting,
-	}
-
-	if runName, err := parseRunName(run, dwf); err == nil {
-		run.Title = runName
-	} else {
-		log.Error("ParseRunName: %v", err)
-	}
+	run.EventPayload = string(eventPayload)
 
 	// cancel running jobs of the same workflow
 	if err := CancelPreviousJobs(