Skip to content

Commit 1427959

Browse files
committed
fix label of --id in admin delete user
This pr fixes the label descriptor of `gitea admin delete user` but also adds a `--username` option. Fix #13995 Signed-off-by: Andrew Thornton <[email protected]>
1 parent b8c58ed commit 1427959

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

cmd/admin.go

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,15 @@ var (
125125
}
126126

127127
microcmdUserDelete = cli.Command{
128-
Name: "delete",
129-
Usage: "Delete specific user",
130-
Flags: []cli.Flag{idFlag},
128+
Name: "delete",
129+
Usage: "Delete specific user",
130+
Flags: []cli.Flag{cli.Int64Flag{
131+
Name: "id",
132+
Usage: "ID of user",
133+
}, cli.StringFlag{
134+
Name: "username",
135+
Usage: "Username",
136+
}},
131137
Action: runDeleteUser,
132138
}
133139

@@ -463,15 +469,21 @@ func runListUsers(c *cli.Context) error {
463469
}
464470

465471
func runDeleteUser(c *cli.Context) error {
466-
if !c.IsSet("id") {
467-
return fmt.Errorf("--id flag is missing")
472+
if !c.IsSet("id") && !c.IsSet("username") {
473+
return fmt.Errorf("--id or --username missing")
468474
}
469475

470476
if err := initDB(); err != nil {
471477
return err
472478
}
473479

474-
user, err := models.GetUserByID(c.Int64("id"))
480+
var err error
481+
var user *models.User
482+
if c.IsSet("id") {
483+
user, err = models.GetUserByID(c.Int64("id"))
484+
} else {
485+
user, err = models.GetUserByName(c.String("username"))
486+
}
475487
if err != nil {
476488
return err
477489
}

docs/content/doc/usage/command-line.en-us.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ Admin operations:
6969
- `gitea admin user list`
7070
- `delete`:
7171
- Options:
72-
- `--id`: ID of user to be deleted. Required.
72+
- `--username`: Username of user to be deleted.
73+
- `--id`: ID of user to be deleted.
74+
- One of `--id` or `--username` is required.
7375
- Examples:
7476
- `gitea admin user delete --id 1`
7577
- `create`: - Options: - `--name value`: Username. Required. As of gitea 1.9.0, use the `--username` flag instead. - `--username value`: Username. Required. New in gitea 1.9.0. - `--password value`: Password. Required. - `--email value`: Email. Required. - `--admin`: If provided, this makes the user an admin. Optional. - `--access-token`: If provided, an access token will be created for the user. Optional. (default: false). - `--must-change-password`: If provided, the created user will be required to choose a newer password after

0 commit comments

Comments
 (0)