hide target selector if tag exists

Author: Zettat123

options/locale/locale_en-US.ini

@@ -2288,6 +2288,8 @@ release.edit_subheader = Releases organize project versions.
 release.tag_name = Tag name
 release.target = Target
 release.tag_helper = Choose an existing tag or create a new tag.
+release.tag_helper_new = New tag. This tag will be created from the target.
+release.tag_helper_existing = Existing tag.
 release.title = Title
 release.content = Content
 release.prerelease_desc = Mark as Pre-Release

templates/repo/release/new.tmpl

@@ -20,22 +20,27 @@
 						<b>{{.tag_name}}</b><span class="at">@</span><strong>{{.tag_target}}</strong>
 					{{else}}
 						<input id="tag-name" name="tag_name" value="{{.tag_name}}" placeholder="{{.locale.Tr "repo.release.tag_name"}}" autofocus required maxlength="255">
-						<span class="at">@</span>
-						<div class="ui selection dropdown">
-							<input type="hidden" name="tag_target" value="{{.tag_target}}"/>
-							{{svg "octicon-git-branch"}}
-							<div class="text">
-								{{.locale.Tr "repo.release.target"}} :
-								<strong id="repo-branch-current">{{.Repository.DefaultBranch}}</strong>
-							</div>
-							{{svg "octicon-triangle-down" 14 "dropdown icon"}}
-							<div class="menu">
-								{{range .Branches}}
-									<div class="item" data-value="{{.}}">{{.}}</div>
-								{{end}}
+						<input id="tag-name-editor" type="hidden" data-existing-tags={{Json .Tags}} data-tag-helper={{ .locale.Tr "repo.release.tag_helper" }} data-tag-helper-new={{ .locale.Tr "repo.release.tag_helper_new" }} data-tag-helper-existing={{ .locale.Tr "repo.release.tag_helper_existing" }} />
+						<span id="tag-target-selector">
+							<span class="at">@</span>
+							<div class="ui selection dropdown">
+								<input type="hidden" name="tag_target" value="{{.tag_target}}"/>
+								{{svg "octicon-git-branch"}}
+								<div class="text">
+									{{.locale.Tr "repo.release.target"}} :
+									<strong id="repo-branch-current">{{.Repository.DefaultBranch}}</strong>
+								</div>
+								{{svg "octicon-triangle-down" 14 "dropdown icon"}}
+								<div class="menu">
+									{{range .Branches}}
+										<div class="item" data-value="{{.}}">{{.}}</div>
+									{{end}}
+								</div>
 							</div>
+						</span>
+						<div>
+							<span id="tag-helper" class="help">{{.locale.Tr "repo.release.tag_helper"}}</span>
 						</div>
-						<span class="help">{{.locale.Tr "repo.release.tag_helper"}}</span>
 					{{end}}
 				</div>
 			</div>

web_src/js/features/tag-editor.js

@@ -0,0 +1,29 @@
+import $ from 'jquery';
+
+export function initTagNameEditor() {
+    const el = document.getElementById('tag-name-editor');
+    if (!el) return;
+
+    const existingTags = JSON.parse(el.getAttribute('data-existing-tags'))
+    if (!Array.isArray(existingTags)) return
+
+    const defaultTagHelperText = el.getAttribute('data-tag-helper')
+    const newTagHelperText = el.getAttribute('data-tag-helper-new')
+    const existingTagHelperText = el.getAttribute('data-tag-helper-existing')
+
+    $('#tag-name').on('keyup', function(e) {
+        const value = e.target.value
+        if (existingTags.includes(value)) {
+            // If the tag already exists, hide the target branch selector.
+            $('#tag-target-selector').hide()
+            $('#tag-helper').text(existingTagHelperText)
+        } else {
+            $('#tag-target-selector').show()
+            if (typeof value == 'string' && value.length > 0) {
+              $('#tag-helper').text(newTagHelperText)
+            } else {
+              $('#tag-helper').text(defaultTagHelperText)
+            }
+        }
+    })
+}

web_src/js/index.js

@@ -90,6 +90,7 @@ import {initFormattingReplacements} from './features/formatting.js';
 import {initCopyContent} from './features/copycontent.js';
 import {initCaptcha} from './features/captcha.js';
 import {initRepositoryActionView} from './components/RepoActionView.vue';
+import {initTagNameEditor} from './features/tag-editor.js';
 
 // Run time-critical code as soon as possible. This is safe to do because this
 // script appears at the end of <body> and rendered HTML is accessible at that point.
@@ -198,4 +199,6 @@ $(document).ready(() => {
   initUserAuthWebAuthnRegister();
   initUserSettings();
   initViewedCheckboxListenerFor();
+
+  initTagNameEditor();
 });